Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Golangci-lint Incompatibility with newer versions of Go? #663

Closed
jwebster7 opened this issue Sep 5, 2019 · 12 comments
Closed

Golangci-lint Incompatibility with newer versions of Go? #663

jwebster7 opened this issue Sep 5, 2019 · 12 comments
Labels
bug Something isn't working

Comments

@jwebster7
Copy link

I'm running version Go v1.13 and GoLangCI-Lint v1.17.1.
.golangci.yml:
goconfig.txt
Go Version: go1.13 darwin/amd64

I'm experiencing some encoding issues when I run GoLangCI-Lint against my code.
It looks like the linter is raising issue with the Go standard libraries (strings, fmt, etc.).

*golangci-lint run output
main.go:1: /usr/local/go/src/strconv/quote.go:405:12: ValidString not declared by package utf8 (typecheck)

main.go:1: /usr/local/go/src/bytes/reader.go:98:18: DecodeRune not declared by package utf8 (typecheck)

package main
pkg/cpu/cpu.go:1: /usr/local/go/src/fmt/scan.go:1200:16: DecodeRuneInString not declared by package utf8 (typecheck)

package ------
pkg/------/------.go:1: /usr/local/go/src/path/match.go:200:15: DecodeRuneInString not declared by package utf8 (typecheck)

@jwebster7 jwebster7 changed the title GoLangCI-Lint Incompatibility with newer versions of Go? Golangci-lint Incompatibility with newer versions of Go? Sep 5, 2019
@nnraju31
Copy link

nnraju31 commented Sep 5, 2019

I am having same issue

@andrewhoff
Copy link

Same here ☝️

@majst01
Copy link

majst01 commented Sep 6, 2019

same

@nexeck
Copy link

nexeck commented Sep 6, 2019

Rebuild golangci-lint with go 1.13 :-)

@cloudlena
Copy link

This is a duplicate of #659.

@moul
Copy link

moul commented Sep 8, 2019

Can a maintainer release a new version built with go 1.13?

The suggested CI method from the README is broken

@jirfag
Copy link
Member

jirfag commented Sep 10, 2019

Hi,
golangci-lint now supports go1.13,
and I've published the v1.18.0 release today. It's built by go1.13.

@jirfag jirfag closed this as completed Sep 10, 2019
@tobiassjosten
Copy link

I ran into the same problem, updated to 1.19.0 just now, but the errors remain.

$ golangci-lint run
apsis/client.go:1: /usr/local/Cellar/go/1.13/libexec/src/strconv/quote.go:405:12: ValidString not declared by package utf8 (typecheck)
package apsis
dogrus/dogrus.go:1: /usr/local/Cellar/go/1.13/libexec/src/strings/strings.go:980:20: DecodeRuneInString not declared by package utf8 (typecheck)
package dogrus
entity/error.go:1: /usr/local/Cellar/go/1.13/libexec/src/strconv/quote.go:405:12: ValidString not declared by package utf8 (typecheck)
package entity
klirr/account.go:1: /usr/local/Cellar/go/1.13/libexec/src/bufio/scan.go:395:19: DecodeRune not declared by package utf8 (typecheck)
package klirr
medley/client.go:1: /usr/local/Cellar/go/1.13/libexec/src/bytes/reader.go:98:18: DecodeRune not declared by package utf8 (typecheck)
package medley
vakt/client.go:1: /usr/local/Cellar/go/1.13/libexec/src/strconv/quote.go:405:12: ValidString not declared by package utf8 (typecheck)
package vakt
$ brew info golangci-lint
golangci/tap/golangci-lint: stable 1.19.0
Fast linters runner for Go.
https://golangci.com
/usr/local/Cellar/golangci-lint/1.19.0 (5 files, 21.7MB) *
  Built from source on 2019-09-27 at 10:30:26
From: https://github.com/golangci/homebrew-tap/blob/master/Formula/golangci-lint.rb

Am I doing something wrong?

@jirfag
Copy link
Member

jirfag commented Sep 27, 2019

Please make a new issue with —version output

@tobiassjosten
Copy link

My bad! I had a go get installation that overrode the brew installation. The latter didn't have a --version flag, so it wasn't as obvious as it could have been. :) All sorted now and it works fine with 1.19.1. 👍

@temoto
Copy link

temoto commented Oct 5, 2019

@tpounds of all Github issues related to this problem, this one is the most helpful: contains clear description of error and solution, maybe it's not quite "invalid" as end of thread suggests.

temoto added a commit to temoto/robotstxt that referenced this issue Oct 5, 2019
temoto added a commit to temoto/alive that referenced this issue Oct 5, 2019
temoto added a commit to temoto/extremofile that referenced this issue Oct 5, 2019
temoto added a commit to temoto/limitmap that referenced this issue Oct 5, 2019
temoto added a commit to temoto/gpio-cdev-go that referenced this issue Oct 5, 2019
@tpounds tpounds added bug Something isn't working and removed declined labels Oct 5, 2019
@tpounds
Copy link
Contributor

tpounds commented Oct 5, 2019

@temoto Agreed. I must have incorrectly categorized this when I was traiging the backlog of open issues. I've updated this issue with a more appropriate label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests