Fix lint errors on files with //line directive #1065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the target files contains `//line` directive and it indicates a non-go file, the linter is going to handle it as a go file, which results in failure. The cause of this issue is that the linters (`Analyzer`s) are using `pass.Fset.Position()`. This func returns the adjusted position using `//line` directive. The example project reported in golangci#998 has `//line` directive that indicates other non-go file. According to the description of "Compiler Directives” (https://golang.org/cmd/compile/#hdr-Compiler_Directives), line directives is mainly used for reporting original positions to the generators or something. On linters of golangci-lint, `pass.Fset.Position()` is used just to aggregate file names; we don't have to adjust positions. This changes `Analyzer`s that use `pass.Fset.Position()` to aggregate file names to use `pass.Fset.PositionFor()` with `adjusted == false`. Relates: golangci#998
|
hi, thank you for the pull request! Please, add some tests for it. For example, when I've done a similar fix I've added these tests. |
|
Thank you for you review. I see, I'll do it. |
|
I've added tests for the fix. |
|
thank you, I'll look at it a bit later, |
|
thank you! |
4 tasks
ansiwen
added a commit
to ansiwen/golangci-lint
that referenced
this pull request
Jul 30, 2022
This change fixes a bug caused that many linters ignored all files that are using Cgo. It was introduced by PR golangci#1065, which assumed that all files referenced by //line directives are non-Go files, which is not true. In the case of Cgo they point to the original Go files which are used by Cgo as templates to generate other Go files. The fix replaces all calls of Pass.Fset.PositionFor with a function `getFileNames()` that first calls Pass.Fset.PositionFor with adjustment, and only if it results in a non-Go file it calls Pass.Fset.PositionFor again without adjustment. Fixes: golangci#2910 Signed-off-by: Sven Anderson <sven@anderson.de>
ansiwen
added a commit
to ansiwen/golangci-lint
that referenced
this pull request
Jul 30, 2022
This change fixes a bug caused that many linters ignored all files that are using Cgo. It was introduced by PR golangci#1065, which assumed that all files referenced by //line directives are non-Go files, which is not true. In the case of Cgo they point to the original Go files which are used by Cgo as templates to generate other Go files. The fix replaces all calls of Pass.Fset.PositionFor with a function getFileNames() that first calls Pass.Fset.PositionFor with adjustment, and only if it results in a non-Go file it calls Pass.Fset.PositionFor again without adjustment. Fixes: golangci#2910 Signed-off-by: Sven Anderson <sven@anderson.de>
ansiwen
added a commit
to ansiwen/golangci-lint
that referenced
this pull request
Jul 30, 2022
This change fixes a bug caused that many linters ignored all files that are using Cgo. It was introduced by PR golangci#1065, which assumed that all files referenced by //line directives are non-Go files, which is not true. In the case of Cgo they point to the original Go files which are used by Cgo as templates to generate other Go files. The fix replaces all calls of Pass.Fset.PositionFor with a function getFileNames() that first calls Pass.Fset.PositionFor with adjustment, and only if it results in a non-Go file it calls Pass.Fset.PositionFor again without adjustment. Fixes: golangci#2910 Signed-off-by: Sven Anderson <sven@anderson.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will fix #998.
If the target files contains
//linedirective and it indicates a non-go file, the linter is going to handle it as a go file, which results in failure.The cause of this issue is that the linters (
Analyzers) are usingpass.Fset.Position().This func returns the adjusted position using
//linedirective.The example project reported in #998 has
//linedirective that indicates other non-go file.According to the description of Compiler Directives, line directives is mainly used for reporting original positions to the generators or something.
On linters of golangci-lint,
pass.Fset.Position()is used just to aggregate file names; we don't have to adjust positions.This pull request changes
Analyzers that usepass.Fset.Position()to aggregate file names to usepass.Fset.PositionFor()withadjusted == false.