-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gomoddirectives linter. #1817
Conversation
b4a8eaf
to
76ba882
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks sane, meets the use cases we discussed; I have not tested this locally, but will trust the author/ci to assert its correctness. should we add some tests to verify anything, or are we trusting that is done in the upstream library?
It's not possible with the current test system, but I added a lot of tests in my lib.
FYI I'm a maintainer of golangci-lint, my code is on a public repo on GitHub, I added a lot of tests, I followed the guideline from the Go team to get the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I trust you @ldez! ❤️
https://github.com/ldez/gomoddirectives