Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate golint #1965

Merged
merged 3 commits into from
May 10, 2021
Merged

Deprecate golint #1965

merged 3 commits into from
May 10, 2021

Conversation

ldez
Copy link
Member

@ldez ldez commented May 10, 2021

@ldez ldez added the linter: update version Update version of linter label May 10, 2021
bombsimon
bombsimon approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP golint!

@ldez ldez merged commit f95b1ed into golangci:master May 10, 2021
@ldez ldez deleted the feat/golint-deprecated branch May 10, 2021 22:50
@alexadhy alexadhy mentioned this pull request May 29, 2021
Merged
dannykopping pushed a commit to dannykopping/loki that referenced this pull request Sep 19, 2021
Fixing CI deprecations
37a8fde 
Replacing deprecated golint with revive (golangci/golangci-lint#1965)

Removing interfacer (golangci/golangci-lint#1755)

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@dannykopping dannykopping mentioned this pull request Sep 19, 2021
Merged
2 tasks
dannykopping pushed a commit to grafana/loki that referenced this pull request Sep 21, 2021
CI: Fixing linter deprecations (#4353)
d5b6d05 
* Fixing CI deprecations

Replacing deprecated golint with revive (golangci/golangci-lint#1965)

Removing interfacer (golangci/golangci-lint#1755)

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>

* Further suggestions from Marco in #1002

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>

* Clarify instruction

Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
@Gusted Gusted mentioned this pull request Nov 10, 2021
Closed
8 tasks
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez @SeigeC
golint: deprecation (golangci#1965)
f362180
@y-yagi y-yagi mentioned this pull request Sep 22, 2023
Merged
@ldez ldez mentioned this pull request Mar 3, 2024
Merged
@ldez ldez added this to the v1.40 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
linter: update version Update version of linter
Projects
None yet
Milestone
v1.40
Development

Successfully merging this pull request may close these issues.

golint will be deprecated
2 participants
@ldez @bombsimon