Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suggest golangci-lint help linters #2117

Merged
merged 1 commit into from
Aug 5, 2021
Merged

suggest golangci-lint help linters #2117

merged 1 commit into from
Aug 5, 2021

Conversation

smantic
Copy link
Contributor

@smantic smantic commented Jul 18, 2021

golangci-lint linters wont run when you have an unknown linter. golangci-lint help linters works.

@boring-cyborg
Copy link

boring-cyborg bot commented Jul 18, 2021

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2021

CLA assistant check
All committers have signed the CLA.

@ldez
Copy link
Member

ldez commented Jul 18, 2021

Hello,

what do you call an "unknown linter"?

@ldez ldez added area: docs feedback required Requires additional feedback labels Jul 18, 2021
@smantic
Copy link
Contributor Author

smantic commented Jul 18, 2021

@ldez a linter name string (feed from config file or flags) that doesnt match any existing linter names. whenever if v.m.GetLinterConfigs(name) == nil this unknown linters error gets thrown

@ldez
Copy link
Member

ldez commented Jul 18, 2021

why do you want to display the linter's list if you have an invalid linter in your configuration?
From my point of view, it's better to show the error.

@smantic
Copy link
Contributor Author

smantic commented Jul 19, 2021

@ldez Please view the diff. My suggested change is just one word in the error message that is printed when you have an invalid linter in your config.

@ldez ldez removed the feedback required Requires additional feedback label Jul 19, 2021
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit a07b1fa into golangci:master Aug 5, 2021
@golangci-automator
Copy link

Hey, @smantic — we just merged your PR to golangci-lint! 🔥🚀

golangci-lint is built by awesome people like you. Let us say “thanks”: we just invited you to join the GolangCI organization on GitHub.
This will add you to our team of maintainers. Accept the invite by visiting this link.

By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.
More information about contributing is here.

Thanks again!

SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added this to the v1.42 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants