-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add errname linter #2129
Add errname linter #2129
Conversation
Hey, thank you for opening your first Pull Request ! |
@ldez, also, I am not a native english speaker. Maybe u can suggest more pleasant form for error message than
? (especially interested in articles) |
Hello @Antonboom, could you sign the CLA? |
@ldez, done |
@ldez, something else? |
Sorry, it's always the same thing: a day has only 24h 😸 |
@Antonboom take a look to Antonboom/errname#2 |
@ldez, thanks! Merged. This MR updated too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hey, @Antonboom — we just merged your PR to
By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests. Thanks again! |
* Add errname linter * bump errname version
Hello!
https://github.com/Antonboom/errname
I'm sorry, I am confused about
goanalysis.LoadMode
andlinter.Preset*
. I don't see any documentation that explains which constants are best for your linter.Thank u for any suggestions.