Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runner: exit with non-zero code when linter fails #2410

Closed
wants to merge 1 commit into from
Closed

runner: exit with non-zero code when linter fails #2410

wants to merge 1 commit into from

Conversation

ezradiniz
Copy link

I think this problem was introduced when runErr was removed here

Fixes #2357

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 12, 2021

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Dec 12, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ldez ldez self-requested a review December 13, 2021 00:05
@ldez
Copy link
Member

ldez commented Dec 13, 2021

Hello,

It was a choice to not stop all linters if one linter fail.

I think that is not the right way to fix #2357

@ldez ldez added the blocked Need's direct action from maintainer label Dec 13, 2021
@ezradiniz
Copy link
Author

Alright, I'll close this PR, thanks for reviewing

@ezradiniz ezradiniz closed this Dec 13, 2021
@ldez ldez added declined and removed blocked Need's direct action from maintainer labels Dec 13, 2021
@bombsimon bombsimon mentioned this pull request Jan 10, 2022
Merged
@bombsimon bombsimon mentioned this pull request Feb 16, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez Awaiting requested review from ldez

Assignees
No one assigned
Labels
declined
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Run returns 0 on build failure
3 participants
@ezradiniz @CLAassistant @ldez