Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exclude docs from unrelated go tests on ci #2823

Closed
wants to merge 1 commit into from

Conversation

@kamilsk kamilsk requested a review from a team May 4, 2022 13:20
@kamilsk
Copy link
Contributor Author

kamilsk commented May 4, 2022

related comment #1792 (comment)

@ldez ldez added the blocked Need's direct action from maintainer label May 4, 2022
@ldez ldez requested review from ldez and removed request for a team May 4, 2022 13:39
@ldez ldez self-assigned this May 4, 2022
@ldez
Copy link
Member

ldez commented May 4, 2022

This is not possible, because:

  • As you can see your restriction doesn't work because the use of paths and the glob expression are not right.
  • The checks related to PRs are required all the time, we cannot disable the requirements or add a condition on requirements.
  • there are some others problems, that I think I don't need to describe because the previous ones are blockers.

If you want a demo you can take a look here: https://github.com/ldez/fictional-umbrella

Also, this is just a kind of workaround and not a real solution for #1792 (comment).

I will decline the PR.

@ldez ldez closed this May 4, 2022
@ldez ldez added declined and removed blocked Need's direct action from maintainer labels May 4, 2022
@kamilsk
Copy link
Contributor Author

kamilsk commented May 4, 2022

As you can see your restriction doesn't work because the use of paths and the glob expression are not right.

this can be corrected

If you want a demo you can take a look here: https://github.com/ldez/fictional-umbrella

nice, thanks! but I already have worked solution https://github.com/octomation/go-tool/blob/7c04ec2c8a4ab61d8e7b92f5f5df45a81173090a/.github/workflows/ci.yml#L4-L9, and reduced unnecessary checks

as I see, I made a mistake here and have to replace paths with paths-ignore

Also, this is just a kind of workaround and not a real solution for #1792 (comment).

I didn't try to fix it, I just try eliminating meaningless work

The checks related to PRs are required all the time, we cannot disable the requirements or add a condition on requirements.

why do you need to run unrelated checks? it allows reducing the amount of time and GitHub actions utilization

@kamilsk kamilsk deleted the github-actions-tunning branch May 4, 2022 15:10
@ldez
Copy link
Member

ldez commented May 4, 2022

why do you need to run unrelated checks?

Because technically it's not possible to define conditional requirements/checks.
In Github, you can just add or remove a check.
All checks are required on basic PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants