contextcheck: bump to v1.0.6 && re-enable #3102

sylvia7788 · 2022-08-16T10:05:05Z

refactor using the Fact feature to solve the cache problem, which may cause a little bit slow, so we add a switch to turn off Fact if you use this lint in docker ci

linters-settings:
  contextcheck:
    disable-fact: true

add new check for net/http.HandleFunc
re-enable for go1.18

kkHAIKE/contextcheck@v1.0.4...v1.0.6

ldez · 2022-08-16T12:12:00Z

kkHAIKE/contextcheck#4

ldez · 2022-08-16T12:30:27Z

the option need to be added and commented in https://github.com/golangci/golangci-lint/blob/master/.golangci.reference.yml

ldez · 2022-08-18T23:44:46Z

I did some benchmarks.

current version (v1.0.4)

goos: linux
goarch: amd64
pkg: github.com/golangci/golangci-lint/test/bench
cpu: 11th Gen Intel(R) Core(TM) i7-11850H @ 2.50GHz
Benchmark_linters
Benchmark_linters/contextcheck
Benchmark_linters/contextcheck/golangci/golangci-lint
2022/08/19 01:39:54 contextcheck on golangci/golangci-lint (34 kLoC): time: 1.585822751s
Benchmark_linters/contextcheck/golangci/golangci-lint-16         	       1	1596072941 ns/op
Benchmark_linters/contextcheck/gohugoio/hugo
2022/08/19 01:40:05 contextcheck on gohugoio/hugo (162 kLoC): time: 10.742384616s
Benchmark_linters/contextcheck/gohugoio/hugo-16                  	       1	10753507654 ns/op
Benchmark_linters/contextcheck/ethereum/go-ethereum
2022/08/19 01:40:17 contextcheck on ethereum/go-ethereum (333 kLoC): time: 11.878757337s
Benchmark_linters/contextcheck/ethereum/go-ethereum-16           	       1	11891778826 ns/op
Benchmark_linters/contextcheck/astaxie/beego
2022/08/19 01:40:19 contextcheck on astaxie/beego (75 kLoC): time: 2.607164538s
Benchmark_linters/contextcheck/astaxie/beego-16                  	       1	2615898098 ns/op
Benchmark_linters/contextcheck/hashicorp/terraform
2022/08/19 01:40:29 contextcheck on hashicorp/terraform (353 kLoC): time: 9.547556869s
Benchmark_linters/contextcheck/hashicorp/terraform-16            	       1	9566533803 ns/op
Benchmark_linters/contextcheck/hashicorp/consul
    bench_test.go:77: can't run golangci-lint: exit status 3, level=error msg="[runner] Panic: contextcheck: package \"proxycfg\" (isInitialPkg: true, needAnalyzeSource: true): runtime error: invalid memory address or nil pointer dereference: goroutine 21098 [running]:\nruntime/debug.Stack()\n\t/home/ldez/go1.19/src/runtime/debug/stack.go:24 +0x65\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func1()\n\tgo/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:101 +0x155\npanic({0x15502e0, 0x204d040})\n\t/home/ldez/go1.19/src/runtime/panic.go:884 +0x212\ngithub.com/sylvia7788/contextcheck.(*runner).buildPkg(0xc01e9e8090?, 0xc023b80b60)\n\tgithub.com/sylvia7788/contextcheck@v1.0.4/contextcheck.go:273 +0x32\ngithub.com/sylvia7788/contextcheck.(*runner).checkFuncWithCtx(0xc02a463d08, 0xc0338ec4e0)\n\tgithub.com/sylvia7788/contextcheck@v1.0.4/contextcheck.go:327 +0x350\ngithub.com/sylvia7788/contextcheck.(*runner).run(0xc02a463d08, 0xc01d4d69c0)\n\tgithub.com/sylvia7788/contextcheck@v1.0.4/contextcheck.go:101 +0x2c5\ngithub.com/sylvia7788/contextcheck.NewRun.func1(0x153ab00?)\n\tgithub.com/sylvia7788/contextcheck@v1.0.4/contextcheck.go:57 +0x33\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyze(0xc000915e80)\n\tgo/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:187 +0x9d6\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe.func2()\n\tgo/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:105 +0x1d\ngithub.com/golangci/golangci-lint/pkg/timeutils.(*Stopwatch).TrackStage(0xc0021986e0, {0x16ecee5, 0xc}, 0xc0016e4748)\n\tgo/src/github.com/golangci/golangci-lint/pkg/timeutils/stopwatch.go:111 +0x4a\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*action).analyzeSafe(0xc000c56e40?)\n\tgo/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_action.go:104 +0x85\ngithub.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze.func2(0xc000915e80)\n\tgo/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_loadingpackage.go:80 +0xb4\ncreated by github.com/golangci/golangci-lint/pkg/golinters/goanalysis.(*loadingPackage).analyze\n\tgo/src/github.com/golangci/golangci-lint/pkg/golinters/goanalysis/runner_loadingpackage.go:75 +0x1eb\n"
        level=warning msg="[runner] Can't run linter contextcheck: contextcheck: contextcheck: package \"proxycfg\" (isInitialPkg: true, needAnalyzeSource: true): runtime error: invalid memory address or nil pointer dereference"
        level=error msg="Running error: 1 error occurred:\n\t* can't run linter contextcheck: contextcheck: contextcheck: package \"proxycfg\" (isInitialPkg: true, needAnalyzeSource: true): runtime error: invalid memory address or nil pointer dereference\n\n"
--- FAIL: Benchmark_linters/contextcheck/hashicorp/consul
Benchmark_linters/contextcheck/traefik/traefik
2022/08/19 01:40:53 contextcheck on traefik/traefik (132 kLoC): time: 7.914312883s
Benchmark_linters/contextcheck/traefik/traefik-16                	       1	7922969369 ns/op
Benchmark_linters/contextcheck/go_source_code
2022/08/19 01:40:56 contextcheck on go source code (339 kLoC): time: 2.402004264s
Benchmark_linters/contextcheck/go_source_code-16                 	       1	2439689606 ns/op

PR (DisableFact : false)

goos: linux
goarch: amd64
pkg: github.com/golangci/golangci-lint/test/bench
cpu: 11th Gen Intel(R) Core(TM) i7-11850H @ 2.50GHz
Benchmark_linters
Benchmark_linters/contextcheck
Benchmark_linters/contextcheck/golangci/golangci-lint
2022/08/19 01:04:43 contextcheck on golangci/golangci-lint (34 kLoC): time: 3.697457285s
Benchmark_linters/contextcheck/golangci/golangci-lint-16         	       1	3707201692 ns/op
Benchmark_linters/contextcheck/gohugoio/hugo
2022/08/19 01:05:00 contextcheck on gohugoio/hugo (162 kLoC): time: 17.153564158s
Benchmark_linters/contextcheck/gohugoio/hugo-16                  	       1	17165378500 ns/op
Benchmark_linters/contextcheck/ethereum/go-ethereum
2022/08/19 01:05:16 contextcheck on ethereum/go-ethereum (333 kLoC): time: 15.409161416s
Benchmark_linters/contextcheck/ethereum/go-ethereum-16           	       1	15420912400 ns/op
Benchmark_linters/contextcheck/astaxie/beego
2022/08/19 01:05:21 contextcheck on astaxie/beego (75 kLoC): time: 4.796906305s
Benchmark_linters/contextcheck/astaxie/beego-16                  	       1	4805741875 ns/op
Benchmark_linters/contextcheck/hashicorp/terraform
2022/08/19 01:05:37 contextcheck on hashicorp/terraform (353 kLoC): time: 15.727273433s
Benchmark_linters/contextcheck/hashicorp/terraform-16            	       1	15745659405 ns/op
Benchmark_linters/contextcheck/hashicorp/consul
2022/08/19 01:06:03 contextcheck on hashicorp/consul (502 kLoC): time: 25.84789742s
Benchmark_linters/contextcheck/hashicorp/consul-16               	       1	25873111418 ns/op
Benchmark_linters/contextcheck/traefik/traefik
2022/08/19 01:06:23 contextcheck on traefik/traefik (132 kLoC): time: 19.6706203s
Benchmark_linters/contextcheck/traefik/traefik-16                	       1	19682449913 ns/op
Benchmark_linters/contextcheck/go_source_code
2022/08/19 01:06:27 contextcheck on go source code (339 kLoC): time: 4.599884425s
Benchmark_linters/contextcheck/go_source_code-16                 	       1	4635807624 ns/op

PR (DisableFact : true)

goos: linux
goarch: amd64
pkg: github.com/golangci/golangci-lint/test/bench
cpu: 11th Gen Intel(R) Core(TM) i7-11850H @ 2.50GHz
Benchmark_linters
Benchmark_linters/contextcheck
Benchmark_linters/contextcheck/golangci/golangci-lint
2022/08/19 01:10:48 contextcheck on golangci/golangci-lint (34 kLoC): time: 1.659752684s
Benchmark_linters/contextcheck/golangci/golangci-lint-16         	       1	1667280979 ns/op
Benchmark_linters/contextcheck/gohugoio/hugo
2022/08/19 01:11:00 contextcheck on gohugoio/hugo (162 kLoC): time: 11.171557053s
Benchmark_linters/contextcheck/gohugoio/hugo-16                  	       1	11184450116 ns/op
Benchmark_linters/contextcheck/ethereum/go-ethereum
2022/08/19 01:11:12 contextcheck on ethereum/go-ethereum (333 kLoC): time: 12.09250438s
Benchmark_linters/contextcheck/ethereum/go-ethereum-16           	       1	12105824323 ns/op
Benchmark_linters/contextcheck/astaxie/beego
2022/08/19 01:11:15 contextcheck on astaxie/beego (75 kLoC): time: 2.610712093s
Benchmark_linters/contextcheck/astaxie/beego-16                  	       1	2620544178 ns/op
Benchmark_linters/contextcheck/hashicorp/terraform
2022/08/19 01:11:24 contextcheck on hashicorp/terraform (353 kLoC): time: 9.620776204s
Benchmark_linters/contextcheck/hashicorp/terraform-16            	       1	9640397704 ns/op
Benchmark_linters/contextcheck/hashicorp/consul
2022/08/19 01:11:40 contextcheck on hashicorp/consul (502 kLoC): time: 15.526233151s
Benchmark_linters/contextcheck/hashicorp/consul-16               	       1	15551715790 ns/op
Benchmark_linters/contextcheck/traefik/traefik
2022/08/19 01:11:48 contextcheck on traefik/traefik (132 kLoC): time: 7.495335096s
Benchmark_linters/contextcheck/traefik/traefik-16                	       1	7506985549 ns/op
Benchmark_linters/contextcheck/go_source_code
2022/08/19 01:11:50 contextcheck on go source code (339 kLoC): time: 2.310968916s
Benchmark_linters/contextcheck/go_source_code-16                 	       1	2349470457 ns/op

.golangci.reference.yml

kkHAIKE · 2022-08-25T09:51:08Z

@ldez how to trigger the depnedbot... i will release a new tag for a bugfix

ldez · 2022-08-25T09:53:28Z

@kkHAIKE you have to wait, the update happens every Sunday

golangci-lint/.github/dependabot.yml

Line 7 in bddc63a

day: "sunday"

In some cases, I can trigger the bot but this doesn't mean that we will create a release just for your linter.

kkHAIKE mentioned this pull request Aug 16, 2022

proposal: notify when the request.Context is not used kkHAIKE/contextcheck#5

Closed

ldez added feedback required Requires additional feedback linter: update version Update version of linter labels Aug 16, 2022

ldez changed the title ~~contextcheck: bump to v1.0.6 && re-enable for go1.18~~ contextcheck: bump to v1.0.6 && re-enable Aug 17, 2022

ldez removed the feedback required Requires additional feedback label Aug 17, 2022

ldez requested changes Aug 19, 2022

View reviewed changes

.golangci.reference.yml Outdated Show resolved Hide resolved

ldez mentioned this pull request Aug 21, 2022

build(deps): bump github.com/sylvia7788/contextcheck from 1.0.4 to 1.0.6 #3121

Closed

sylvia7788 and others added 4 commits August 23, 2022 13:21

contextcheck: re-enable for go1.18

7c680e9

docs(contextcheck): add disable-fact config

b6b99b5

contextcheck: remove disable-fact config

94a9c43

review

8576746

ldez force-pushed the master branch from 3a47f8d to 8576746 Compare August 23, 2022 11:23

ldez approved these changes Aug 23, 2022

View reviewed changes

ldez merged commit cc2d97f into golangci:master Aug 23, 2022

SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023

contextcheck: bump to v1.0.6 && re-enable (golangci#3102)

555908d

ldez added this to the v1.49 milestone Mar 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

contextcheck: bump to v1.0.6 && re-enable #3102

contextcheck: bump to v1.0.6 && re-enable #3102

sylvia7788 commented Aug 16, 2022 •

edited

Loading

ldez commented Aug 16, 2022

ldez commented Aug 16, 2022

ldez commented Aug 18, 2022 •

edited

Loading

kkHAIKE commented Aug 25, 2022

ldez commented Aug 25, 2022 •

edited

Loading

contextcheck: bump to v1.0.6 && re-enable #3102

contextcheck: bump to v1.0.6 && re-enable #3102

Conversation

sylvia7788 commented Aug 16, 2022 • edited Loading

ldez commented Aug 16, 2022

ldez commented Aug 16, 2022

ldez commented Aug 18, 2022 • edited Loading

kkHAIKE commented Aug 25, 2022

ldez commented Aug 25, 2022 • edited Loading

sylvia7788 commented Aug 16, 2022 •

edited

Loading

ldez commented Aug 18, 2022 •

edited

Loading

ldez commented Aug 25, 2022 •

edited

Loading