Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use first issue without inline on mergeLineIssues on multiple issues #3316

Merged
merged 5 commits into from
Mar 7, 2024
Merged

fix: use first issue without inline on mergeLineIssues on multiple issues #3316

merged 5 commits into from
Mar 7, 2024

Conversation

peakle
Copy link
Contributor

@peakle peakle commented Oct 23, 2022 •
edited by ldez
Loading

fixes #3230

@peakle peakle added bug Something isn't working area: auto-fix labels Oct 23, 2022
@ldez ldez self-requested a review October 23, 2022 12:08
@ldez ldez changed the title use first issue without inline on mergeLineIssues on multiplie issues fix: use first issue without inline on mergeLineIssues on multiplie issues Oct 23, 2022
@ldez

This comment was marked as off-topic.

Sign in to view
@peakle

This comment was marked as off-topic.

Sign in to view
@peakle peakle requested a review from alexandear October 30, 2022 11:35
@peakle
Copy link
Contributor Author

peakle commented Nov 8, 2022

@ldez , @alexandear any updates?

@peakle
Copy link
Contributor Author

peakle commented Nov 17, 2022

@ldez ping

@ldez ldez force-pushed the fixInlineInMergeLineIssues branch from 7d6b249 to a1c24cc Compare December 26, 2022 21:11
@ldez ldez removed the request for review from alexandear January 20, 2023 11:41
@Antonboom Antonboom requested a review from alexandear March 16, 2023 05:01
@ldez ldez force-pushed the fixInlineInMergeLineIssues branch from 4a61966 to 13b6954 Compare March 7, 2024 18:49
@ldez ldez added this to the next milestone Mar 7, 2024
ldez
ldez approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry for the extremely late review.

@ldez ldez merged commit 1b0dbb0 into golangci:master Mar 7, 2024
12 checks passed
@ldez ldez changed the title fix: use first issue without inline on mergeLineIssues on multiplie issues fix: use first issue without inline on mergeLineIssues on multiple issues Mar 8, 2024
@bombsimon bombsimon mentioned this pull request Mar 13, 2024
Closed
4 tasks
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

@alexandear alexandear alexandear approved these changes

Assignees
No one assigned
Labels
area: auto-fix bug Something isn't working
Projects
None yet
Milestone
v1.57
Development

Successfully merging this pull request may close these issues.

Using --fix with both gofumpt and gocritic linters deletes comment lines
3 participants
@peakle @ldez @alexandear