Skip to content

docs: add note about binary requirement for plugin #3468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 12, 2023

Conversation

philiplinell
Copy link
Contributor

The binary releases aren't compatible with private linters. This commit adds a section in the new linters documentation that describes the requirements for private linters to work.

The binary releases aren't compatible with private linters. This commit
adds a section in the new linters documentation that describes the
requirements for private linters to work.
@boring-cyborg
Copy link

boring-cyborg bot commented Jan 11, 2023

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

CLAassistant commented Jan 11, 2023

CLA assistant check
All committers have signed the CLA.

@philiplinell
Copy link
Contributor Author

When trying to add a new private linter to golangci-lint I encountered some unexpected hurdles. This PR intends to save time for other users trying to create new private linters by describing the requirements.

Related discussions and issues:

@ldez ldez added enhancement New feature or improvement area: docs labels Jan 11, 2023
@ldez ldez self-requested a review January 11, 2023 09:06
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez enabled auto-merge (squash) January 12, 2023 13:33
@ldez ldez merged commit 8f6de2c into golangci:master Jan 12, 2023
SeigeC pushed a commit to SeigeC/golangci-lint that referenced this pull request Apr 4, 2023
@ldez ldez added this to the v1.51 milestone Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs enhancement New feature or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants