-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add linter zerologlint #3726
add linter zerologlint #3726
Conversation
Hey, thank you for opening your first Pull Request ! |
In order for a pull request adding a linter to be reviewed, the linter and the PR must follow some requirements.
Pull Request Description
Linter
The Linter Tests Inside Golangci-lint
|
I'm really interesting in this linter, and tried it on a huge private repo, got bunch of panics, mostly on the generated pb (proto) files. |
here is the fix: ykadowak/zerologlint#2 |
@ldez |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I'd like to add https://github.com/ykadowak/zerologlint.
This linter detects the wrong usage of
zerolog
that a user forgets to dispatch withSend
orMsg
.I'm not sure if this linter is applicable to this repository because this is specific only for
zerolog
. Also this linter uses SSA.