Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump go-simpler.org/sloglint from 0.1.2 to 0.2.0 #4166

Merged
merged 1 commit into from
Nov 5, 2023
Merged

build(deps): bump go-simpler.org/sloglint from 0.1.2 to 0.2.0 #4166

merged 1 commit into from
Nov 5, 2023

Conversation

tmzane
Copy link
Contributor

@tmzane tmzane commented Oct 26, 2023 •
edited by ldez
Loading

A few options have been added:

  • ContextOnly: enforce using methods that accept a context
  • KeyNamingCase: enforce a single key naming convention

go-simpler/sloglint@v0.1.2...v0.2.0

@ldez
Copy link
Member

ldez commented Oct 26, 2023

Hello,

we use dependabot to update dependencies, and we update the code inside the PR created by dependabot. The update happens once a week by default.
So you don't need to create a PR.

@ldez ldez changed the title build(deps): bump sloglint from 0.1.2 to 0.2.0 build(deps): bump go-simpler.org/sloglint from 0.1.2 to 0.2.0 Oct 26, 2023
@ldez ldez added dependencies Relates to an upstream dependency linter: update version Update version of linter go Pull requests that update Go code labels Oct 26, 2023
@ldez ldez self-requested a review October 26, 2023 18:58
@tmzane
Copy link
Contributor Author

tmzane commented Oct 26, 2023

But I won't have access to dependabot's branch to push the new code, will I?

@ldez
Copy link
Member

ldez commented Oct 26, 2023

But I won't have access to dependabot's branch to push the new code, will I?

You will not but maintainers handle that for you.

@ldez
Copy link
Member

ldez commented Oct 26, 2023

We will accept and merge this PR, there is no major problem.

It was mainly to inform you about the linter update flow.

@tmzane
Copy link
Contributor Author

tmzane commented Oct 26, 2023

Got it, thanks for the info!

This was referenced Oct 29, 2023
Closed
Merged
ldez
ldez approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit f17fef3 into golangci:master Nov 5, 2023
11 checks passed
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
@tmzane @Antonboom
build(deps): bump go-simpler.org/sloglint from 0.1.2 to 0.2.0 (golang…
70ff9e6 
…ci#4166)
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Milestone
v1.56
Development

Successfully merging this pull request may close these issues.
2 participants
@tmzane @ldez