Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps): bump github.com/ghostiam/protogetter from 0.2.3 to 0.3.1 #4167

Merged
merged 1 commit into from
Nov 5, 2023
Merged

build(deps): bump github.com/ghostiam/protogetter from 0.2.3 to 0.3.1 #4167

merged 1 commit into from
Nov 5, 2023

Conversation

ghostiam
Copy link
Contributor

@ghostiam ghostiam commented Oct 27, 2023 •
edited
Loading

Changes in code since the latest version, which was in golangci-lint.
ghostiam/protogetter@v0.2.3...v0.3.1

@ldez
Copy link
Member

ldez commented Oct 27, 2023

Hello,

we use dependabot to update dependencies, and we update the code inside the PR created by dependabot. The update happens once a week by default.
So you don't need to create a PR.

@ldez ldez added dependencies Relates to an upstream dependency linter: update version Update version of linter go Pull requests that update Go code labels Oct 27, 2023
@ghostiam
Copy link
Contributor Author

ghostiam commented Oct 27, 2023 •
edited
Loading

Hello, @ldez
But the new version will not be compatible with the old code in golangci-lint, since the config has been passed as a parameter when creating a linter.

Previously, the linter configuration was not provided.

@ldez ldez changed the title protogetter: added the ability to configure the linter build(deps): bump github.com/ghostiam/protogetter from0.2.3 to 0.3.1 Oct 27, 2023
@ldez ldez changed the title build(deps): bump github.com/ghostiam/protogetter from0.2.3 to 0.3.1 build(deps): bump github.com/ghostiam/protogetter from 0.2.3 to 0.3.1 Oct 27, 2023
@ldez
Copy link
Member

ldez commented Oct 27, 2023

Configuration changes are expected, there is no difference with the other linters.

It was mainly to inform you about the linter update flow.

@ldez ldez self-requested a review October 27, 2023 14:27
@ldez ldez merged commit 97cb905 into golangci:master Nov 5, 2023
11 checks passed
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
@ghostiam @Antonboom
build(deps): bump github.com/ghostiam/protogetter from 0.2.3 to 0.3.1 (…
d954b13 
…golangci#4167)
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
@alexandear alexandear mentioned this pull request Mar 15, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ldez ldez ldez approved these changes

Assignees
No one assigned
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Milestone
v1.56
Development

Successfully merging this pull request may close these issues.
2 participants
@ghostiam @ldez