Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump go-simpler.org/musttag from v0.7.2 to v0.8.0 #4201

Merged
merged 3 commits into from
Nov 13, 2023

Conversation

ldez
Copy link
Member

@ldez ldez commented Nov 13, 2023

go-simpler/musttag@v0.7.2...v0.8.0

This update is done by hand because the author of musttag has changed the module name.

go.tmz.dev/musttag -> go-simpler.org/musttag

@ldez ldez added dependencies Relates to an upstream dependency linter: update version Update version of linter go Pull requests that update Go code labels Nov 13, 2023
Copy link
Member

@alexandear alexandear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexandear
Copy link
Member

Maybe it's needed to change getThanksList in scripts. If the linter is musttag or sloglint set author to the tmzane.

@ldez ldez merged commit 89bfdc0 into golangci:master Nov 13, 2023
11 checks passed
@ldez ldez deleted the feat/update-musttag branch November 13, 2023 16:01
Antonboom pushed a commit to Antonboom/golangci-lint that referenced this pull request Mar 3, 2024
@ldez ldez modified the milestone: v1.56 Mar 4, 2024
rebtoor added a commit to rebtoor/dataplane-operator that referenced this pull request Apr 16, 2024
The version of `golangci-lint` hook configured in the pre-commit config
file, `v1.55.2`, contains a dependency to a deprecated url of the library
`musttag`, and installing pre-commit hooks from scratch caused this
error:

```bash
    pkg/golinters/musttag.go:4:2: unrecognized import path "go.tmz.dev/musttag": parse https://go.tmz.dev/musttag?go-get=1: no go-import meta tags ()
```

This problem has been fixed with this [1] commit, so we have updated the
hook to the last available version.

[1] golangci/golangci-lint#4201

Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
@mrngm
Copy link

mrngm commented Jul 22, 2024

Just a heads-up for people running with GOPROXY=direct or a custom proxy: the domain name tmz.dev is not registered anymore. This prevents either building or installing versions of golangci-lint between v1.51.0 where it was added (#3386) and v1.56.0 where it was renamed (this PR).

This may happen as well in the (unlikely) event of the default setting GOPROXY=https://proxy.golang.org,direct and a lack of a copy of go.tmz.dev/musttag prior to v0.8.0 on proxy.golang.org.

(I'm happening to perform a bisect between 1.54.0 and 1.56.1 and ran into this problem on a local machine)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Relates to an upstream dependency go Pull requests that update Go code linter: update version Update version of linter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants