dev: fix GO_VERSION in post release workflow #4926
Merged
+7
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
ldez
changed the title
ldez
changed the title
Member
This only impacts the generators of docs and JSON files, there is no impact on the documentation or the generated public assets. |
ldez
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple jobs in the GitHub post-release workflow that reference the
GO_VERSIONenvironment variable, but it is only defined for theupdate-docs(akaUpdate readme) job.This means that the static assets for version
1.60.1are built with Go1.22instead of1.23.You can confirm this by comparing the version of Go used in the
actions/setup-go@5step of the Update readme job to the one in Update GitHub Action assets.