Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: consistent WithSince versions #5022

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Conversation

raeperd
Copy link
Contributor

@raeperd raeperd commented Sep 15, 2024

Hi I found inconsistent usage in Since in linters page

image

So I fixed it with simple v prefix if not exists

@raeperd raeperd changed the title fix: Fix inconsistent WithSinceVersion arguments Fix inconsistent WithSinceVersion arguments Sep 15, 2024
@ldez ldez changed the title Fix inconsistent WithSinceVersion arguments docs: inconsistent WithSinceVersion Sep 15, 2024
@ldez ldez added area: docs topic: cosmetic changes contain cosmetic improvements labels Sep 15, 2024
@ldez ldez added this to the next milestone Sep 15, 2024
@ldez ldez changed the title docs: inconsistent WithSinceVersion docs: consistent WithSince versiond Sep 15, 2024
@ldez ldez changed the title docs: consistent WithSince versiond docs: consistent WithSince versions Sep 15, 2024
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldez ldez merged commit dba8700 into golangci:master Sep 15, 2024
16 checks passed
uudashr pushed a commit to uudashr/golangci-lint that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs topic: cosmetic changes contain cosmetic improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants