Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: error if typecheck is enabled or disabled #5543

Merged
merged 1 commit into from
Mar 13, 2025
Merged

feat: error if typecheck is enabled or disabled #5543

merged 1 commit into from
Mar 13, 2025

Conversation

ldez
Copy link
Member

@ldez ldez commented Mar 13, 2025 •
edited
Loading

@ldez ldez added enhancement New feature or improvement area: config Related to .golangci.yml and/or cli options labels Mar 13, 2025
@ldez ldez added this to the v2-unreleased milestone Mar 13, 2025
bombsimon
bombsimon approved these changes Mar 13, 2025
View reviewed changes
Copy link
Member

@bombsimon bombsimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now let's spin the lottery wheel and see if this result in more or less issues 😅

@ldez
Copy link
Member Author

ldez commented Mar 13, 2025

We will create a dedicated donation "box" like the box used for children when they say bad words.

Each user that opens an issue about typecheck will have to put a coin in it 😸

@ldez ldez merged commit b62fb8c into golangci:main Mar 13, 2025
19 checks passed
@ldez ldez deleted the feat/typecheck-check branch March 13, 2025 16:29
@busser busser mentioned this pull request Mar 14, 2025
Closed
@ldez ldez modified the milestones: v2-unreleased, v2 Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexandear alexandear alexandear approved these changes

@bombsimon bombsimon bombsimon approved these changes

Assignees
No one assigned
Labels
area: config Related to .golangci.yml and/or cli options enhancement New feature or improvement
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ldez @alexandear @bombsimon