dev: improve HTTP download error handling for wget and curl
#5962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey, thank you for opening your first Pull Request ! |
- Updated `http_download_curl` to log HTTP errors using `log_err` instead of `log_debug`. - Modified `http_download_wget` to check HTTP status codes, mirroring curl's behavior. - Return exit status 1 for non-200 responses in `http_download_wget`. - Standardized error logging across both download functions.
tjasko
force-pushed
the
fix/install-script-check-http-status
branch
from
6b3e0fa to
cdf68aa
Compare
ldez
added
the
area: install
ldez
changed the title
wget and curlwget and curl
ldez
reviewed
Jul 28, 2025
Comment on lines
+318
to
+320
| if [ "$code" != "200" ]; then | ||
| log_err "http_download_wget received HTTP status $code" | ||
| return 1 |
There was a problem hiding this comment.
this doesn't work in all cases, and it can hide other errors.
$ wget --server-response --quiet -O foo http://example.g 2>&1 | awk '/^ HTTP/{print $2}' | tail -n1
$ echo $?
0
$ wget --server-response --quiet -O foo http://example.g
$ echo $?
4
$ wget --server-response -O foo http://example.g
--2025-07-28 23:19:59-- http://example.g/
Resolving example.g (example.g)... failed: Name or service not known.
wget: unable to resolve host address 'example.g'There was a problem hiding this comment.
Ah, good catch. Will look into it soon enough. Thanks for the quick review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the error handling and consistency between
http_download_curlandhttp_download_wgetininstall.sh.Changes
http_download_curlto uselog_errfor non-200 HTTP status codes instead oflog_debug.http_download_wgetto:wget --server-response.1for non-200 HTTP responses, matching the behavior ofhttp_download_curl.log_errfor better visibility.http_downloadto directly callhttp_download_wgetafter its availability check.Why
Previously,
http_download_wgetdid not validate HTTP response codes, which led to misleading behavior. For example, when GitHub returned an HTTP 503, the installer incorrectly reported that the requested version did not exist:In this case, the tag
v1.64.8did exist, but the underlying issue was a GitHub service error returning a503. By properly checking and logging HTTP response codes, this update makes such scenarios clearer to users and avoids misleading "version not found" messages.