Skip to content

Conversation

@mcncl
Copy link
Contributor

@mcncl mcncl commented Dec 8, 2025

Description

Buildkite offers a golangci-lint plugin for use in CI.

Changes

  • Adds Buildkite to the CI examples with links to resources and a code example

Signed-off-by: Ben McNicholl <git@benmcnicholl.com>
@CLAassistant
Copy link

CLAassistant commented Dec 8, 2025

CLA assistant check
All committers have signed the CLA.

@boring-cyborg
Copy link

boring-cyborg bot commented Dec 8, 2025

Hey, thank you for opening your first Pull Request !

@ldez ldez closed this Dec 8, 2025
@ldez ldez added the declined label Dec 8, 2025
@ldez ldez changed the title Add Buildkite to CI examples spam Dec 8, 2025
@ldez
Copy link
Member

ldez commented Dec 8, 2025

Sorry, maybe I was a bit extreme, but your PR contains several red flags:

  1. The PR description feels AI generated.
  2. The PR description uses the term "offers" and "CI" like the tools that try to integrate them to our CI.
  3. You are working for Buildkite (and you hide the fact to be a member of the Buildkite organization)
  4. I didn't know Buildkite

Spam is a recurring problem, which is why I am taking strong action as quickly as possible.

@ldez ldez changed the title spam Add Buildkite to CI examples Dec 8, 2025
@ldez
Copy link
Member

ldez commented Dec 8, 2025

I will reopen the PR if you can explain why adding Buildkite inside our documentation is something valuable for our community and not only ads.
Because we don't plan to add a doc for all the existing CI or integrations.

@mcncl
Copy link
Contributor Author

mcncl commented Dec 8, 2025

@ldez

  1. Nothing about this was AI written, however I appreciate that the description could be more verbose. I'm happy to expand on it if you like. This feels like the world we live in now, re: AI assumption

  2. I don't really get Q2, however I could change "offers" to "provides" if you feel that language would add clarity

  3. How am I hiding that? Is that something I should declare in the PR? I wrote the plugin, so I thought it might be a good idea to open a PR. If you'd rather only document Git* CI usage then that's a decision for you to make

  4. I guess see (3); I don't mind if this PR gets declined, I'm not in sales etc and this isn't an advertisement for anything. I simply wrote a plugin which allows use of golangci-lint in CI in a way that might feel more natural than running via Docker

Appreciate your time either way.

@ldez
Copy link
Member

ldez commented Dec 9, 2025

This feels like the world we live in now, re: AI assumption

I feel you are underestimating the current level of low-quality, AI-generated content, I am facing, and I am not the only one experiencing this problem.

My current reality is a flood of AI generated content used to spam (phone calls, issues, pull requests, etc.)

I don't really get Q2

I think you don't get it because you are a native English speaker and I'm not.
But we will say this is not so important.


I noted several "problems" with your plugin:

@mcncl
Copy link
Contributor Author

mcncl commented Dec 9, 2025

Appreciate the input @ldez, let me spend some time fixing those up. I don't mind if this stays as declined, the input on ensuing the plugin is in a better state was valuable. Best of luck with the PR spam etc!

@ldez
Copy link
Member

ldez commented Dec 9, 2025

At the beginning this install section was only for the GitHub Action as we maintain it.
And then it grows with GitLab.

I'm not happy with this section and this page. I think I will rewrite/reorganize this page.

I will work on that, and reopen your PR if I found a right way to integrate it.

@ldez ldez changed the title Add Buildkite to CI examples docs: add Buildkite to CI examples Dec 10, 2025
@ldez ldez added area: docs area: install Issue relates to installation or downloading process and removed declined labels Dec 10, 2025
@ldez ldez reopened this Dec 10, 2025
@ldez ldez added this to the unreleased milestone Dec 10, 2025
Copy link
Member

@ldez ldez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the PR #6256 to reorganize this page, so I will merge this PR and move the content in the new dedicated CI page inside my PR.

@ldez ldez merged commit 462163b into golangci:main Dec 10, 2025
18 checks passed
@ldez
Copy link
Member

ldez commented Dec 10, 2025

If Buildkite wants to sponsor golangci-lint, it will be welcomed:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs area: install Issue relates to installation or downloading process

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants