Support go1.13 #670
Merged
Support go1.13 #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jirfag
force-pushed
the
bug/fix-ci-build-on-go-1.11
branch
from
cd86adb to
0556f6a
Compare
jirfag
force-pushed
the
bug/fix-ci-build-on-go-1.11
branch
from
2bbe9ff to
f443182
Compare
jirfag
force-pushed
the
bug/fix-ci-build-on-go-1.11
branch
5 times, most recently
from
16b2e6d to
4f89a38
Compare
Setup Travis CI to run on go 1.12 and 1.13. Update info about go versions in README. Rebuild go.mod,go.sum on go1.13.
jirfag
force-pushed
the
bug/fix-ci-build-on-go-1.11
branch
from
4f89a38 to
dc152d3
Compare
|
FWIW: w/o the go.mod changes here I can't |
|
Additional note - Even with golangci-lint @ 1.17.1 $ go get github.com/golangci/golangci-lint/cmd/golangci-lint
go: github.com/golangci/golangci-lint@v1.17.1 requires
github.com/go-critic/go-critic@v0.0.0-20181204210945-1df300866540: invalid pseudo-version: does not match version-control timestamp (2019-05-26T07:48:19Z) |
|
Yes, this PR predates 1.17.1. You'd need to get |
|
@zikaeroh Well master.... go get github.com/golangci/golangci-lint/cmd/golangci-lint@master
go: finding github.com/golangci/golangci-lint/cmd master
go: finding github.com/golangci/golangci-lint/cmd/golangci-lint master
go: finding github.com/golangci master
go: finding github.com/golangci/golangci-lint master
go: finding github.com master
go: downloading github.com/golangci/golangci-lint v1.17.2-0.20190909185456-6163a8a79084
go: extracting github.com/golangci/golangci-lint v1.17.2-0.20190909185456-6163a8a79084
# github.com/golangci/golangci-lint/pkg/lint
../../go/pkg/mod/github.com/golangci/golangci-lint@v1.17.2-0.20190909185456-6163a8a79084/pkg/lint/load.go:278:3: unknown field 'Logf' in struct literal of type "golang.org/x/tools/go/packages".Config |
|
PS: That is because the replacements need to be pulled forward into our project. |
|
Looking forward to a new release from this :) |
|
I can't get rid of replacements until my pull requests to upstreams are merged. But I've changed replaced x/tools to be compatible with the replacement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup Travis CI to run on go 1.12 and 1.13.
Update info about go versions in README.
Rebuild go.mod,go.sum on go1.13.
Thank you for the pull request!