Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spanish translation skeleton #16

Closed
wants to merge 9 commits into from
Closed

Add spanish translation skeleton #16

wants to merge 9 commits into from

Conversation

eduardomontalvo
Copy link

Skeleton for translate the project to Spanish language

@goldbergyoni
Copy link
Owner

@eduardomontalvo WOW! amazing

  1. Is this Google translate or manual work?
  2. How would you suggest to display a new language?
  3. Shouldn't we add different files for Spanish (i.e. not modify existing)?

cc @idori

@idori
Copy link
Contributor

idori commented Nov 4, 2017

I don't see any standard set by github for translating repositories.
I can suggest to create a /translations or /i18n sub-folder with a ISO language code folder name for each language.
This will make it easy to add new translations as all relative links should still work so there is no need to add a suffix/prefix to each file.

@eduardomontalvo
Copy link
Author

@i0natan

  1. It's a manual work.
  2. I think that the correct way is create a folder with translations. For example: https://github.com/jwasham/coding-interview-university and add a new link in the repo introduction for a new translation.
  3. Yes, but your advices are good to know in spanish language community, after we can add a new links in Spanish with the best resources for node.

@idori
Exactly! ISO is a good idea, but for example in Spanish, the specification contains a single code for each spanish-speak country. For example, I propose modify the folder and rename by es and wrap the Spanish language with common words for all countries (without slangs or regionalisms).

@goldbergyoni
Copy link
Owner

Manual work? wow

@eduardomontalvo @idori what should be the UX: (a) we display links in the top to different languages (b) home page stays in English and link to each section contains few more links: 'Spanish'' Chineese', etc

@eduardomontalvo
Copy link
Author

@i0natan I think that the b is the best way. @idori what do you think?

@goldbergyoni
Copy link
Owner

I also vote for B

@idori you're the UX master (along with other things)

@idori
Copy link
Contributor

idori commented Nov 6, 2017

I'm actually thinking (a) is better - leave the repository as is and add a list of links for the translations sub folders at the top (i.e. a link at the top to the Spanish translation will lead to /translations/es/readme.md.

@eduardomontalvo I think you changed one of the original sections in your fork - section project structure is translated in the original folder instead of under /translations

@goldbergyoni
Copy link
Owner

@eduardomontalvo @idori my Spanish friend that it's written in a very clear and professional language

We plan to publish project milestones this week (new major releases), this can be on the list as it's a big contribution


<br/><br/>


### Blog Quote: "Scaling requires scaling of the entire application"
From the blog MartinFowler.com
### Cita de Blog: "El escalado requiere escalar toda la aplicación"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When it's a quote, do not translate the title of the blog, article, book, chapter of the book, etc. where the quote comes from. By convention, keep the title in the original language and only translate the content of the quote.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's true! my mistake! thx 👍



### Example: test your API in-process using supertest (popular testing package)
### Ejemplo: prueba tu API en proceso usanso supertest (paquete de testing popular)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe is usando and not usanso

@goldbergyoni
Copy link
Owner

@idori can u add to our milestones and think how to push forward?

@goldbergyoni
Copy link
Owner

@eduardomontalvo sorry for the delay, we're ready to kick it off and be glad if you lead it. No need to spend upfront mass effort - we may gather few collaborators and translate slowly.

Once this is done you can get your name boldly on top of the Spanish page + added to project core collaborators. LMK whether this is of interest?

@eduardomontalvo
Copy link
Author

@i0natan I'm glad to hear that. I'm ready to work with you and the community :)

@goldbergyoni
Copy link
Owner

@eduardomontalvo see here:
#95

do you need help in copying the content to the new branch?

goldbergyoni pushed a commit that referenced this pull request Mar 11, 2018
[Chinese translation]merge into master
@sagirk
Copy link
Contributor

sagirk commented Sep 19, 2018

@eduardomontalvo @metcoder95 @idori @i0natan Seems this PR has remained stalled for quite some time now. What can we do to nudge it in the direction of progress and move it closer to mergeability?

@goldbergyoni
Copy link
Owner

@sagirk The Spanish translation is now handled by @desko27 in #95

We should assign each core member a language, I can handle Spanish

@metcoder95
Copy link

@eduardomontalvo @metcoder95 @idori @i0natan Seems this PR has remained stalled for quite some time now. What can we do to nudge it in the direction of progress and move it closer to mergeability?

I think we could assign to each member who can work with Spanish a section of the text to work with it. For example, I can work with breakincomponents.md, and on.

@desko27
Copy link

desko27 commented Sep 25, 2018

Hey, I recently finished one of my projects and I have extra time for this. Everything is translated indeed, I'm opening new PR so we can move this forward, if you agree.

@sagirk
Copy link
Contributor

sagirk commented Sep 27, 2018

I think we could assign to each member who can work with Spanish a section of the text to work with it. For example, I can work with breakincomponents.md, and on.

Sounds good, @metcoder95! Thanks for the suggestion. Once @i0natan and @desko27 open a PR with the so far translated content, we could run with this approach.

Hey, I recently finished one of my projects and I have extra time for this. Everything is translated indeed, I'm opening new PR so we can move this forward, if you agree.

@i0natan 👆

@goldbergyoni
Copy link
Owner

@desko27 I shall wait for you PR, help with merging it and then we can progress with @metcoder95

Did I get it right?

@desko27
Copy link

desko27 commented Sep 29, 2018

@i0natan that's totally right, working on it, it's my priority right now and I'm opening a PR ASAP.

@stale
Copy link

stale bot commented Mar 25, 2019

Hello there! 👋
This issue has gone silent. Eerily silent. ⏳
We currently close issues after 100 days of inactivity. It has been 90 days since the last update here.
If needed, you can keep it open by replying here.
Thanks for being a part of the Node.js Best Practices community! 💚

@stale stale bot added the stale label Mar 25, 2019
@stale stale bot closed this Apr 4, 2019
goldbergyoni pushed a commit that referenced this pull request Mar 27, 2021
* Translation of `frontendout.md`

* Fix bad translation

* Correction following the review of MrYamous
elite0226 pushed a commit to elite0226/nodebestpractices that referenced this pull request Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants