-
Notifications
You must be signed in to change notification settings - Fork 10.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backport README.md from master and update README.korean.md #651
Conversation
- The language of README.korean.md was Chinese, Replaced README.korean.md contents with latest version of README.md
- Only translated title, and some contents of main page
Added korean translation
…n-uronly14me 1.1 and 1.2 translated to Korean
Merge branch 'korean-translation' into korean-translation-uronly14me
…n-uronly14me Translate section 4 to Korean
This will also delete unnecessary line.
Fix some typo
…n-uronly14me Korean translation
…tion Translate 6.1 to korean
8d8dd37
to
c9cffad
Compare
405bc15
to
5dc2214
Compare
Hi @songe, nice work! Any reason you are targeting the branch korean-translation instead of master? I'm asking given that the Korean translation is also available on the master branch. |
@kevynb Thanks! I actually created a PR against Personally, I think it'd make more sense to merge these directly into |
Also update section 4 to sound more natural in Korean
@kevynb I've rebased the branch against |
I guess we should wait for another maintainer to chime before merging into master since that’s what the contributing docs says.
@goldbergyoni for example?
… On 25 Mar 2020, at 07:00, songe ***@***.***> wrote:
@kevynb <https://github.com/kevynb> I've rebased the branch against master with korean-translation branch merged it. The change is master-ready, and I've also changed the PR base to master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub <#651 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABFWLH4A2HXJDMC3J6K5FJLRJGMXZANCNFSM4LOGWZCA>.
|
@kevynb @goldbergyoni Any updates on this? I want to continue working on this and translate the rest of the document, but I'd like to make sure this gets merged in first since this is a big change. |
@songe Thanks for the great improvements and sorry waiting - was a bit busy due to the crazy & hectic worldwide situation. Going to be much more available now. @all-contributors please add @songe for content |
I've put up a pull request to add @songe! 🎉 |
Backport README.md from master and update README.korean.md
Here is the list of all the changes I've made in this PR:
README.md
changes frommaster
intoREADME.korean.md
It may look like a large change since I removed all the ^M characters from the file, but the actual changes are much smaller and organized by commits.
👉 Preview