Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport README.md from master and update README.korean.md #651

Merged
merged 31 commits into from
Mar 30, 2020

Conversation

songe
Copy link
Contributor

@songe songe commented Mar 18, 2020

Here is the list of all the changes I've made in this PR:

  • Merge branch 'korean-translation' into master
  • Remove all ^M characters from README.korean.md
  • Update 1.1-2.7 & 4 to sound more natural in Korean
  • Backport README.md changes from master into README.korean.md

It may look like a large change since I removed all the ^M characters from the file, but the actual changes are much smaller and organized by commits.

👉 Preview

goldbergyoni and others added 26 commits May 6, 2018 15:04
- The language of README.korean.md was Chinese, Replaced README.korean.md contents with latest version of README.md
- Only translated title, and some contents of main page
…n-uronly14me

1.1 and 1.2 translated to Korean
Merge branch 'korean-translation' into korean-translation-uronly14me
…n-uronly14me

Translate section 4 to Korean
This will also delete unnecessary line.
@songe songe changed the base branch from master to korean-translation March 18, 2020 07:23
@songe songe force-pushed the master branch 2 times, most recently from 8d8dd37 to c9cffad Compare March 18, 2020 08:02
@songe songe changed the title Backport sections 5-7 from English README & translate section 4 Backport README.md from master and update README.korean.md Mar 18, 2020
@songe songe force-pushed the master branch 3 times, most recently from 405bc15 to 5dc2214 Compare March 19, 2020 18:19
@kevynb
Copy link
Collaborator

kevynb commented Mar 24, 2020

Hi @songe, nice work! Any reason you are targeting the branch korean-translation instead of master? I'm asking given that the Korean translation is also available on the master branch.

@songe
Copy link
Contributor Author

songe commented Mar 24, 2020

@kevynb Thanks! I actually created a PR against master, but then noticed that the guidelines in #94 said to merge changes into korean-translation branch.

Personally, I think it'd make more sense to merge these directly into master, and I'd be happy to update the PR to target master instead.

@songe songe changed the base branch from korean-translation to master March 25, 2020 05:57
@songe
Copy link
Contributor Author

songe commented Mar 25, 2020

@kevynb I've rebased the branch against master with korean-translation branch merged it. The change is master-ready, and I've also changed the PR base to master.

@kevynb
Copy link
Collaborator

kevynb commented Mar 25, 2020 via email

@songe
Copy link
Contributor Author

songe commented Mar 29, 2020

@kevynb @goldbergyoni Any updates on this? I want to continue working on this and translate the rest of the document, but I'd like to make sure this gets merged in first since this is a big change.

@goldbergyoni goldbergyoni merged commit 5d9b3f1 into goldbergyoni:master Mar 30, 2020
@goldbergyoni
Copy link
Owner

@songe Thanks for the great improvements and sorry waiting - was a bit busy due to the crazy & hectic worldwide situation. Going to be much more available now.

@all-contributors please add @songe for content

@allcontributors
Copy link
Contributor

@goldbergyoni

I've put up a pull request to add @songe! 🎉

elite0226 pushed a commit to elite0226/nodebestpractices that referenced this pull request Oct 31, 2022
Backport README.md from master and update README.korean.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants