Handle goldendict:// and dict:// URI schemes #1632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specifications: https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html https://specifications.freedesktop.org/shared-mime-info-spec/shared-mime-info-spec-latest.html#idm45659000071008 GoldenDict now opens the supported URIs on GNU/Linux. However, platform-specific changes may be necessary to make this work on other operating systems. Hopefully the required changes can be implemented without recompiling GoldenDict, similarly to the simple modification of GoldenDict's desktop file in this commit. In this case, a user can make the necessary changes and test locally, then create a pull request to complete URI scheme support on his/her preferred OS. This feature has been requested in goldendict#735, goldendict#1139 and goldendict#1280. The implementation is based on goldendict#1624 and its review in goldendict#1625.
This was referenced May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specifications:
https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-latest.html https://specifications.freedesktop.org/shared-mime-info-spec/shared-mime-info-spec-latest.html#idm45659000071008
GoldenDict now opens the supported URIs on GNU/Linux. However, platform-specific changes may be necessary to make this work on other operating systems. Hopefully the required changes can be implemented without recompiling GoldenDict, similarly to the simple modification of GoldenDict's desktop file in this commit. In this case, a user can make the necessary changes and test locally, then create a pull request to complete URI scheme support on his/her preferred OS.
This feature has been requested in #735, #1139 and #1280. The implementation is based on #1624 and its review in #1625.