Introduce Options and OptionsMonad #427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 21, 2019
Open
RyanGlScott
force-pushed
the
wip/T204
branch
from
148f694
to
8a28033
Compare
goldfirere
requested changes
Dec 23, 2019
RyanGlScott
force-pushed
the
wip/T204
branch
2 times, most recently
from
486fec7
to
fdf87a5
Compare
goldfirere
reviewed
Dec 26, 2019
This patch introduces an `Options` data type and an `mtl`-like `OptionsMonad` class for monads that carry `Options`. At present, the only things one can do with `Options` are: * Toggle the generation of `SingKind` instances. Suppressing `SingKind` instances provides an effective workaround for #150. * Hook into the TH machinery's naming conventions for promoted and singled names. This fixes #204. The vast majority of this patch simply adds plumbing by using `OptionsMonad` in places that need it. See the `D.S.TH.Options` module for where most of the new code is housed, as well as the `T150` and `T204` test cases for examples of how to use it.
RyanGlScott
force-pushed
the
wip/T204
branch
from
fdf87a5
to
131beb5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces an
Optionsdata type and anmtl-likeOptionsMonadclass for monads that carryOptions. At present, the only things one can do withOptionsare:SingKindinstances. SuppressingSingKindinstances provides an effective workaround for Promote GADTs #150.The vast majority of this patch simply adds plumbing by using
OptionsMonadin places that need it. See theD.S.TH.Optionsmodule for where most of the new code is housed, as well as theT150andT204test cases for examples of how to use it.