[#690] Test coverage: Improve sonar quality metrics

goldmansachs · Jul 23, 2024 · baed162 · baed162
1 parent 42ebb2c
commit baed162
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/dmn-core/src/main/java/com/gs/dmn/feel/synthesis/FEELToTripleNativeVisitor.java b/dmn-core/src/main/java/com/gs/dmn/feel/synthesis/FEELToTripleNativeVisitor.java
@@ -791,7 +791,7 @@ protected Triple makeCondition(String feelOperator, Expression<Type> leftOperand
 
     protected Triple makeCondition(String feelOperator, Triple leftOpd, Triple rightOpd, NativeOperator javaOperator) {
         if (javaOperator == null) {
-            handleError(String.format("Operator '%s' cannot be applied to '%s' and '%s'", feelOperator, leftOpd, rightOpd));
+            handleError(makeOperatorErrorMessage(feelOperator, leftOpd, rightOpd));
             return null;
         } else {
             if (javaOperator.getCardinality() == 2) {
@@ -809,7 +809,7 @@ protected Triple makeCondition(String feelOperator, Triple leftOpd, Triple right
                     }
                 }
             } else {
-                handleError(String.format("Operator '%s' cannot be applied to '%s' and '%s'", feelOperator, leftOpd, rightOpd));
+                handleError(makeOperatorErrorMessage(feelOperator, leftOpd, rightOpd));
                 return null;
             }
         }
@@ -820,7 +820,7 @@ protected String rangeOperator(String feelOperatorName, Expression<Type> leftOpe
         if (javaOperator != null) {
             return javaOperator.getName();
         } else {
-            handleError(String.format("Operator '%s' cannot be applied to '%s' and '%s'", feelOperatorName, leftOperand, rightOperand));
+            handleError(makeOperatorErrorMessage(feelOperatorName, leftOperand, rightOperand));
             return null;
         }
     }
@@ -851,4 +851,8 @@ private Triple nameToTriple(String name, String javaName) {
             return this.triples.name(javaName);
         }
     }
+
+    private static String makeOperatorErrorMessage(String feelOperator, Object leftOpd, Object rightOpd) {
+        return String.format("Operator '%s' cannot be applied to '%s' and '%s'", feelOperator, leftOpd, rightOpd);
+    }
 }