Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades usages of Junit 4 to Junit 5. In particular:
junit-vintage-engine
dependency is replaced with thejunit-jupiter-engine
dependency in allpom.xml
files in which it appears.junit-vintange-engine
indmn-core/pom.xml
due to theFEELSuiteIT.java
test file. This file uses theFitNesse
Runner, andFitNesse
does not provide an equivalent mechanism that conforms to Junit 5's Extension model.""
instead of"\"\""
for empty annotations. The tests using these resources were not being run before, but with the introduction of thejupiter-engine
, they are now running and failing due to the use of"\"\""
. The assumption is that""
is the correct format for specifying an empty annotation, ensuring consistency across test resources and fixing the test failures.ftl
files and corresponding test files underdmn-test-cases
to use@org.junit.jupiter.api.Test
annotations instead of@org.junit.Test
java
test files.