Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Junit 5 Upgrade #683

Merged
merged 1 commit into from
Jun 25, 2024
Merged

Junit 5 Upgrade #683

merged 1 commit into from
Jun 25, 2024

Conversation

enzo-inc
Copy link

This PR upgrades usages of Junit 4 to Junit 5. In particular:

  • The junit-vintage-engine dependency is replaced with the junit-jupiter-engine dependency in all pom.xml files in which it appears.
    • An exception to this is that we retain junit-vintange-engine in dmn-core/pom.xml due to the FEELSuiteIT.java test file. This file uses the FitNesse Runner, and FitNesse does not provide an equivalent mechanism that conforms to Junit 5's Extension model.
  • Update json test resources to use "" instead of "\"\"" for empty annotations. The tests using these resources were not being run before, but with the introduction of the jupiter-engine, they are now running and failing due to the use of "\"\"". The assumption is that "" is the correct format for specifying an empty annotation, ensuring consistency across test resources and fixing the test failures.
  • Update the template ftl files and corresponding test files under dmn-test-cases to use @org.junit.jupiter.api.Test annotations instead of @org.junit.Test
  • We update any Junit 4 import statements and expressions in the remaining java test files.

covered by: cerebral-vincenzo_incutti.dco
@opatrascoiu opatrascoiu merged commit 329de1a into goldmansachs:main Jun 25, 2024
2 checks passed
@opatrascoiu
Copy link
Collaborator

Thank you for your contribution :)

@enzo-inc
Copy link
Author

Regarding the usage of the FitNesse Runner in FEELSuiteIT.java, how would you think about migrating this functionality to a Junit 5 compliant format?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants