Updates from upstream #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alliance#454) When an application attempts to open a non-existent path such as `//foo/bar/baz` on Windows, Node generates an error of the form: ``` { errno: -4094, syscall: 'open', code: 'UNKNOWN', path: '//foo/bar/baz' } ``` Prior to this commit, that error would be re-thrown, causing Wasm execution to trap. Now we convert it to a "no-such-device" error instead. Signed-off-by: Joel Dice <joel.dice@fermyon.com>
…ecodealliance#456) The `js_instrinsics` should be defined under the `instantiate` function. Otherwise we get the following error: ``` dist/component/ruby.component.js:73 if (definedResourceTables[toTid]) return rep; ^ ReferenceError: definedResourceTables is not defined ```
Signed-off-by: danbugs <danilochiarlone@gmail.com>
…ecodealliance#461) Fixes bytecodealliance#460 Signed-off-by: Joel Dice <joel.dice@fermyon.com>
# Conflicts: # crates/js-component-bindgen-component/src/lib.rs # package-lock.json # package.json
|
the tests are failing currently with thread '<unnamed>' panicked at crates/spidermonkey-embedding-splicer/src/bindgen.rs:737:51:
no entry found for key
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
(jco componentize) RuntimeError: unreachable
at spidermonkey_embedding_splicer.wasm.__rust_start_panic (wasm://wasm/spidermonkey_embedding_splicer.wasm-012edce2:wasm-function[6700]:0x392a8c)
at spidermonkey_embedding_splicer.wasm.rust_panic (wasm://wasm/spidermonkey_embedding_splicer.wasm-012edce2:wasm-function[6692]:0x3925b1)
at spidermonkey_embedding_splicer.wasm._ZN3std9panicking20rust_panic_with_hook17h50e657195af0239cE (wasm://wasm/spidermonkey_embedding_splicer.wasm-012edce2:wasm-function[6691]:0x392367)
at spidermonkey_embedding_splicer.wasm._ZN3std9panicking19begin_panic_handler28_$u7b$$u7b$closure$u7d$$u7d$17h0187e6969a85aab0E (wasm://wasm/spidermonkey_embedding_splicer.wasm-012edce2:wasm-function[6679]:0x391789)
at spidermonkey_embedding_splicer.wasm._ZN3std10sys_common9backtrace26__rust_end_short_backtrace17h575fb82445d56667E (wasm://wasm/spidermonkey_embedding_splicer.wasm-012edce2:wasm-function[6678]:0x3916f0)
at spidermonkey_embedding_splicer.wasm.rust_begin_unwind (wasm://wasm/spidermonkey_embedding_splicer.wasm-012edce2:wasm-function[6686]:0x391eff)
at spidermonkey_embedding_splicer.wasm._ZN4core9panicking9panic_fmt17ha6764f2272b7fb95E (wasm://wasm/spidermonkey_embedding_splicer.wasm-012edce2:wasm-function[6839]:0x3a0693)
at spidermonkey_embedding_splicer.wasm._ZN4core6option13expect_failed17h4bbb25fdd9d02fc5E (wasm://wasm/spidermonkey_embedding_splicer.wasm-012edce2:wasm-function[6893]:0x3a8363)
at spidermonkey_embedding_splicer.wasm._ZN30spidermonkey_embedding_splicer7bindgen9JsBindgen14iter_resources17heba57e83495056d8E (wasm://wasm/spidermonkey_embedding_splicer.wasm-012edce2:wasm-function[51]:0x15f59)
at spidermonkey_embedding_splicer.wasm._ZN30spidermonkey_embedding_splicer7bindgen9JsBindgen7bindgen17hba69385eb49a1937E (wasm://wasm/spidermonkey_embedding_splicer.wasm-012edce2:wasm-function[50]:0x15449)and i think the same will happen in the official repos, only componentize js is not yet updated there. i will merge this for now for more testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.