Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update wit-parser #93

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Update wit-parser #93

wants to merge 12 commits into from

Conversation

noise64
Copy link
Contributor

@noise64 noise64 commented Oct 10, 2024 •
edited
Loading

Resolves: #90

Apart from the lib updates also includes some cleanups and reorgs for deduplicating some logic shared between the generators.

Also has some TODOs which will be answered or handled with the next stubgen improvement issues, and further cleanups will happen depending on the direction of those.

@noise64 noise64 marked this pull request as ready for review October 15, 2024 16:09
@noise64 noise64 requested a review from vigoo October 16, 2024 15:16
afsalthaj
afsalthaj reviewed Oct 17, 2024
View reviewed changes
wasm-rpc-stubgen/src/commands/log.rs
),
);
}
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afsalthaj afsalthaj afsalthaj left review comments

@vigoo vigoo Awaiting requested review from vigoo

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update wit-parser to the latest one (0.219.0)
2 participants
@noise64 @afsalthaj