This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 284
Remove compatibility check based on app version #3841
Merged
shadeofblue
merged 5 commits into
develop
from
remove-compatibility-check-based-on-app-version
Mar 19, 2019
Merged
Remove compatibility check based on app version #3841
shadeofblue
merged 5 commits into
develop
from
remove-compatibility-check-based-on-app-version
Mar 19, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pawelkisielewicz
requested review from
Krigpl,
shadeofblue,
rwrzesien,
Jakub89,
kbeker and
dybi
February 1, 2019 06:31
ghost
added
the
in progress
label
Feb 1, 2019
Is this change really needed for 0.19? |
@pawelkisielewicz please change base to |
shadeofblue
previously requested changes
Feb 1, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update base
pawelkisielewicz
force-pushed
the
remove-compatibility-check-based-on-app-version
branch
from
February 4, 2019 09:04
e34a4d7
to
71539a4
Compare
shadeofblue
approved these changes
Feb 27, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Codecov Report
@@ Coverage Diff @@
## develop #3841 +/- ##
===========================================
- Coverage 88.61% 88.57% -0.05%
===========================================
Files 211 211
Lines 18415 18400 -15
===========================================
- Hits 16319 16298 -21
- Misses 2096 2102 +6 |
ghost
assigned shadeofblue
Mar 14, 2019
…ty-check-based-on-app-version
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/golemfactory/golem/issues/3025