Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Remove compatibility check based on app version #3841

Merged
merged 5 commits into from
Mar 19, 2019

Conversation

pawelkisielewicz
Copy link
Contributor

@mfranciszkiewicz
Copy link
Contributor

Is this change really needed for 0.19?

@shadeofblue
Copy link
Contributor

@pawelkisielewicz please change base to develop - it wasn't supposed to be included in 0.19

Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update base

@pawelkisielewicz pawelkisielewicz changed the base branch from b0.19 to develop February 4, 2019 08:57
@pawelkisielewicz pawelkisielewicz force-pushed the remove-compatibility-check-based-on-app-version branch from e34a4d7 to 71539a4 Compare February 4, 2019 09:04
@PaweuB PaweuB requested a review from kmazurek February 7, 2019 10:25
@shadeofblue shadeofblue dismissed their stale review February 18, 2019 13:01

base has been updated

Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank_you_roadsign

@codecov
Copy link

codecov bot commented Feb 27, 2019

Codecov Report

Merging #3841 into develop will decrease coverage by 0.04%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #3841      +/-   ##
===========================================
- Coverage    88.61%   88.57%   -0.05%     
===========================================
  Files          211      211              
  Lines        18415    18400      -15     
===========================================
- Hits         16319    16298      -21     
- Misses        2096     2102       +6

@ghost ghost assigned shadeofblue Mar 14, 2019
@shadeofblue shadeofblue merged commit 760170b into develop Mar 19, 2019
@ghost ghost removed the in progress label Mar 19, 2019
@shadeofblue shadeofblue deleted the remove-compatibility-check-based-on-app-version branch March 19, 2019 10:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants