This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Use different Docker image for blender verification #3844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
|
Also closes #3772 |
Krigpl
force-pushed
the
blender_verifier
branch
from
aed5921
to
15b14b5
Compare
|
|
Krigpl
commented
Feb 7, 2019
| for y_offset in offsets: | ||
| crop = rendered_scene.crop((x + x_offset, | ||
| y + y_offset, | ||
| x + width - x_offset, |
There was a problem hiding this comment.
Isn't this the buggy version? - instead of + ?
There was a problem hiding this comment.
Yes it is.
But fix is waiting in different pull request. And previous version wasn't less buggy probably
There was a problem hiding this comment.
Or I can apply this fix in this pull request.
I don't know
There was a problem hiding this comment.
Please apply in this PR, there's no point in submitting known buggy code.
nieznanysprawiciel
approved these changes
Feb 8, 2019
Codecov Report
@@ Coverage Diff @@
## develop #3844 +/- ##
===========================================
+ Coverage 87.75% 87.78% +0.02%
===========================================
Files 216 216
Lines 19068 18954 -114
===========================================
- Hits 16734 16639 -95
+ Misses 2334 2315 -19 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crops are rendered in the same docker run as the rest of the verification.
All these new scripts are taken from https://gitlab.lan.golem.network/lfoniok/blender-docker/tree/graphene-blender-experiments, in particular, that means I won't be able to answer any questions related to them