This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
TaskSession almost stateless #3896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
maaktweluit
suggested changes
Feb 18, 2019
| continue | ||
| if session.task_computer is not None: | ||
| session.task_computer.session_timeout() | ||
| session.dropped() |
There was a problem hiding this comment.
Will dropping the session here change the list of all_sessions? Think it was 2 loops for this reason
There was a problem hiding this comment.
Actually all_sessions is a frozenset() thus it can't change. Also it's a dynamically generated property which is a copy of incoming and outgoing sessions sets combined.
There was a problem hiding this comment.
nice! ok, approving :D
maaktweluit
approved these changes
Feb 18, 2019
jiivan
force-pushed
the
wfr_taskified
branch
from
a506014
to
83181ea
Compare
Codecov Report
@@ Coverage Diff @@
## develop #3896 +/- ##
===========================================
- Coverage 87.77% 87.72% -0.05%
===========================================
Files 216 216
Lines 18941 19081 +140
===========================================
+ Hits 16625 16739 +114
- Misses 2316 2342 +26 |
jiivan
force-pushed
the
wfr_taskified
branch
from
4229200
to
1c8ceca
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on: golemfactory/golem-messages#321
task_idfrom TaskSession