This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Use res_id instead task_id in ResourceManager #3942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
badb
changed the title
shadeofblue
approved these changes
Mar 11, 2019
Codecov Report
@@ Coverage Diff @@
## develop #3942 +/- ##
===========================================
- Coverage 87.77% 87.73% -0.05%
===========================================
Files 216 216
Lines 18977 18966 -11
===========================================
- Hits 16658 16640 -18
- Misses 2319 2326 +7 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This one will be needed if we want to introduce resources per subtask and not just per task.
res_id is used instead of task_id in Resource, ResourceStorage, ResourceManager and ResourceServer.
That way function names and arguments are more universal and we will be able to use them for subtasks resources, additional resources etc.