Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Install as admin #4064

Merged
merged 5 commits into from
Apr 2, 2019
Merged

Install as admin #4064

merged 5 commits into from
Apr 2, 2019

Conversation

Wiezzel
Copy link

@Wiezzel Wiezzel commented Apr 1, 2019

  • ⚠️ FIXME: LocalAppDataFolder property points to admin's AppData folder

@ghost ghost assigned maaktweluit Apr 2, 2019
@maaktweluit maaktweluit marked this pull request as ready for review April 2, 2019 11:07
@mfranciszkiewicz
Copy link
Contributor

mfranciszkiewicz commented Apr 2, 2019

Unfortunately docker-machine is bugged and doesn't properly handle ' in directory names (#4073)

@codecov
Copy link

codecov bot commented Apr 2, 2019

Codecov Report

Merging #4064 into b0.19 will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            b0.19    #4064      +/-   ##
==========================================
+ Coverage   89.17%   89.24%   +0.07%     
==========================================
  Files         205      205              
  Lines       18431    18431              
==========================================
+ Hits        16435    16448      +13     
+ Misses       1996     1983      -13

@shadeofblue shadeofblue merged commit 1ae76b7 into b0.19 Apr 2, 2019
@ghost ghost removed the in progress label Apr 2, 2019
@Wiezzel
Copy link
Author

Wiezzel commented Apr 3, 2019

@maaktweluit What was wrong with USERNAME property? It did work for me.

@maaktweluit
Copy link
Contributor

maaktweluit commented Apr 3, 2019

@Wiezzel where did you see the USERNAME property?

The old code used LogonUser:
https://github.com/golemfactory/golem/pull/4064/files#diff-3ad93633a0b0cea71f784d796e8d15a1L13

It was not present in the new file, so i added it:
https://github.com/golemfactory/golem/pull/4064/files#diff-a06b451cd40ebfcbb43a69af732a35feR10

Then the property was filled with the admin name, so i set RUNNING_USER during the start of the installer and this worked for me

Nice info from AI: https://www.advancedinstaller.com/user-guide/user-information-props.html

@Wiezzel
Copy link
Author

Wiezzel commented Apr 3, 2019

@maaktweluit I tried to use USERNAME here and you deleted it: golemfactory/golem@17fa73f#diff-a06b451cd40ebfcbb43a69af732a35feL4

But nevermind. I tested it again this morning with USERNAME and it didn't work while your solution works fine for me.

@maaktweluit
Copy link
Contributor

AHHH, that is where it went! sorry, did not see that..

Good it works now, lets leave it :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants