This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Always use long Windows paths for shared directories #4078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Name of the share is a hash of the shared directory's path. Any non-canonical forms of the path would break file sharing because they would have a different hash. Therefore we make sure to standardize the path before computing the hash function. This commit improves the path standardization by introducing expansion of shortened paths (a.k.a. 8.3 paths, DOS paths). Such paths have been observed during Golem installation as "Jack Daniel's" user.
Codecov Report
@@ Coverage Diff @@
## b0.19 #4078 +/- ##
==========================================
- Coverage 89.24% 89.24% -0.01%
==========================================
Files 205 205
Lines 18431 18433 +2
==========================================
+ Hits 16449 16450 +1
- Misses 1982 1983 +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Name of the share is a hash of the shared directory's path. Any non-canonical forms of the path would break file sharing because they would have a different hash. Therefore we make sure to standardize the
path before computing the hash function.
This commit improves the path standardization by introducing expansion of shortened paths (a.k.a. 8.3 paths, DOS paths). Such paths have been observed during Golem installation as "Jack Daniel's" user.