This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Call p2pservice.connect_network() once on start #4094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Wiezzel
approved these changes
Apr 8, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4094 +/- ##
===========================================
+ Coverage 88.61% 88.68% +0.07%
===========================================
Files 214 214
Lines 18626 18629 +3
===========================================
+ Hits 16505 16522 +17
+ Misses 2121 2107 -14 |
mfranciszkiewicz
approved these changes
Apr 8, 2019
maaktweluit
added a commit
that referenced
this pull request
Apr 10, 2019
Call p2pservice.connect_network() once on start
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Golem always started with some duplicate peer warnings.
When looking into this i found that
p2pservice.connect_network()is called twice, causing duplicate peer connections.Fixed this bug and improved the logging surrounding it.