Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

Retrieve samples parameter on 'comp.task' RPC #4115

Merged
merged 3 commits into from
Apr 16, 2019
Merged

Conversation

mdtanrikulu
Copy link
Contributor

No description provided.

@mdtanrikulu mdtanrikulu self-assigned this Apr 12, 2019
@ghost ghost added the in progress label Apr 12, 2019
@mdtanrikulu mdtanrikulu requested a review from shadeofblue April 15, 2019 11:09
Copy link
Contributor

@shadeofblue shadeofblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wolfofwallstreet

@shadeofblue
Copy link
Contributor

though @mdtanrikulu please add or modify a test to make sure that this value is covered

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #4115 into b0.19 will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            b0.19    #4115      +/-   ##
==========================================
- Coverage   89.27%   89.27%   -0.01%     
==========================================
  Files         205      205              
  Lines       18461    18431      -30     
==========================================
- Hits        16481    16454      -27     
+ Misses       1980     1977       -3

@shadeofblue shadeofblue merged commit 5d346aa into b0.19 Apr 16, 2019
@shadeofblue shadeofblue deleted the retrieve_samples branch April 16, 2019 14:40
@ghost ghost removed the in progress label Apr 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants