This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Non-hypervised Docker CPU Environment #4235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A temporary subclass of DockerCPUEnvironment that always uses DummyHypervisor and therefore performs no operations on Docker virtual machine. It is meant to enable usage of the new Environment API without removing DockerManager yet. Using standard DockerCPUEnvironment would cause potential conflicts during VM reconfiguration.
Setting up DockerCPUEnvironment in TaskComputer.__init__() requires two conditions to be met: * Twisted reactor running (because prepare() returns a Deferred) * ClientConfigDescriptor with proper memory and CPU settings
Wiezzel
force-pushed
the
env_refactor/non_hypervised_env
branch
from
6b2d253 to
5791443
Compare
Wiezzel
changed the title
maaktweluit
approved these changes
May 27, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4235 +/- ##
===========================================
- Coverage 88.56% 84.87% -3.69%
===========================================
Files 224 224
Lines 19713 19725 +12
===========================================
- Hits 17458 16741 -717
- Misses 2255 2984 +729 |
Client.start() requires to be run with reactor.
Wiezzel
force-pushed
the
env_refactor/non_hypervised_env
branch
3 times, most recently
from
1a0ed96 to
c490983
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4235 +/- ##
=========================================
+ Coverage 88.49% 88.7% +0.2%
=========================================
Files 224 225 +1
Lines 19715 19766 +51
=========================================
+ Hits 17447 17533 +86
+ Misses 2268 2233 -35 |
Wiezzel
force-pushed
the
env_refactor/non_hypervised_env
branch
2 times, most recently
from
4318b05 to
5e868e6
Compare
When a task header with environment prerequistes is received provider will attempt to install the specified prerequisites and report positive support status only if the installation was succesful.
Wiezzel
force-pushed
the
env_refactor/non_hypervised_env
branch
from
c464ef4 to
a068932
Compare
Wiezzel
force-pushed
the
env_refactor/non_hypervised_env
branch
from
a068932 to
db39955
Compare
|
@mfranciszkiewicz @maaktweluit The code is ready for review. The only thing missing is Golem-Messages update. I'll update the requirements as soon as I get to release Golem-Messages with this change: golemfactory/golem-messages#349 |
Golem-Messages 3.8.0 version introduces environment_prerequisites field to TaskHeader.
Krigpl
reviewed
Jun 11, 2019
| @@ -5,6 +5,7 @@ | |||
| from tests.golem.task.dummy import runner, task | |||
|
|
|||
|
|
|||
| @mock.patch('golem.task.taskserver.NonHypervisedDockerCPUEnvironment') | |||
There was a problem hiding this comment.
fyi, if you use mock.Mock() as the second argument you won't need to put the extra _ argument in the test methods.
mfranciszkiewicz
approved these changes
Jun 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A temporary subclass of
DockerCPUEnvironmentthat always usesDummyHypervisorand therefore performs no operations on Docker virtual machine. It is meant to enable usage of the new Environment API without removingDockerManageryet. Using standardDockerCPUEnvironmentwould cause potential conflicts during VM reconfiguration.