This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
node_integration_tests - use granary for key reuse #4276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
etam
suggested changes
Jun 7, 2019
| enabled = True | ||
|
|
||
| @classmethod | ||
| def get(cls, test_dir: Path): |
There was a problem hiding this comment.
Not critical: If you call this second time, with different test_dir you might get a bit surprising results.
There was a problem hiding this comment.
fixed!
Protected our future selves from this by splitting the functions and adding asserts
Please resolve if you like the fix ( only this commit )
|
Is the Granary code available somewhere? |
|
@etam thanks for the comments! will look into them :) the granary is available here: https://github.com/golemfactory/golem-granary |
etam
reviewed
Jun 7, 2019
maaktweluit
force-pushed
the
mwu/int-granary-config
branch
from
12ae6df
to
f7dba38
Compare
etam
reviewed
Jun 7, 2019
maaktweluit
force-pushed
the
mwu/int-granary-config
branch
from
f7dba38
to
f780e59
Compare
maaktweluit
force-pushed
the
mwu/int-granary-config
branch
from
f780e59
to
beadb18
Compare
|
@mfranciszkiewicz thanks for the review, great comments! I have addressed all of them and resolved the simple fixes, please resolve your other comments when happy with the fixes |
etam
approved these changes
Jun 12, 2019
mfranciszkiewicz
approved these changes
Jun 12, 2019
mfranciszkiewicz
approved these changes
Jun 13, 2019
- better name for the key reuse singleton - added comments for all key reuse classes - better default password - better use of json.load / dump
- Improved logging, less private more public calls
maaktweluit
force-pushed
the
mwu/int-granary-config
branch
from
4f3ccc1
to
e34b760
Compare
maaktweluit
force-pushed
the
mwu/int-granary-config
branch
from
e34b760
to
20f86a3
Compare
maaktweluit
added a commit
that referenced
this pull request
Jul 2, 2019
node_integration_tests - use granary for key reuse
Merged
maaktweluit
added a commit
that referenced
this pull request
Jul 18, 2019
node_integration_tests - use granary for key reuse
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The granary is disabled by default.