This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Implement subtasks restart cost estimation RPC #4278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadeofblue
reviewed
Jun 5, 2019
|
@zakaprov -> generally, please run |
kmazurek
changed the title
|
@shadeofblue I ran the integration tests against this branch locally with all tests passing. Tried the same on Buildbot as well (here), with three of the tests failing for reasons unrelated to my changes (geth nodes being out of sync). |
Codecov Report
@@ Coverage Diff @@
## b0.20 #4278 +/- ##
==========================================
+ Coverage 88.58% 88.67% +0.08%
==========================================
Files 223 223
Lines 19710 19712 +2
==========================================
+ Hits 17461 17479 +18
+ Misses 2249 2233 -16 |
This adds the RPC endpoint `comp.task.subtasks.estimated.cost`. It accepts an array of subtask IDs and returns a cost estimation for restarting the selected subtasks.
kmazurek
force-pushed
the
subtasks-restart-estimation
branch
from
2df322d to
f537b6b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
comp.task.subtasks.estimated.cost.disable_concentflag to thecomp.task.restartendpoint.