This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Persistent topups #4345
Merged
Persistent topups #4345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiivan
force-pushed
the
task_payment_topups
branch
from
18455ce to
c1e3e44
Compare
Krigpl
suggested changes
Jun 24, 2019
Krigpl
reviewed
Jun 25, 2019
Krigpl
suggested changes
Jun 26, 2019
jiivan
force-pushed
the
task_payment_topups
branch
from
ac92a71 to
b40ba70
Compare
Krigpl
reviewed
Jun 28, 2019
jiivan
force-pushed
the
task_payment_topups
branch
from
b40ba70 to
d229870
Compare
Krigpl
approved these changes
Jul 2, 2019
| @@ -289,3 +289,29 @@ def test_update_overdue_incomes_already_marked_as_overdue(self): | |||
| income.wallet_operation.refresh().status, | |||
| model.WalletOperation.STATUS.overdue, | |||
| ) | |||
|
|
|||
| def test_received_eth_transfer(self): | |||
There was a problem hiding this comment.
Those two tests do not test different things the way they are implemented right now.
So either remove one of them or introduce some more assertions.
jiivan
force-pushed
the
task_payment_topups
branch
from
f27d31f to
93bb04a
Compare
Codecov Report
@@ Coverage Diff @@
## develop #4345 +/- ##
===========================================
- Coverage 88.49% 87.07% -1.42%
===========================================
Files 225 225
Lines 19835 19831 -4
===========================================
- Hits 17552 17267 -285
- Misses 2283 2564 +281 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.