This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fixed failed subtask count when restarting a finished task #4381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When copying the results of a restarted task, the number of failed subtasks on the new task was being incorrectly set to the total subtasks count. This resulted in the requestor attempting to assign more new subtasks than necessary.
shadeofblue
approved these changes
Jun 24, 2019
maaktweluit
reviewed
Jul 4, 2019
| @@ -190,6 +190,9 @@ def _put_collected_files_together(self, output_file_name, files, arg): | |||
| exec_cmd(cmd) | |||
|
|
|||
| def _get_next_task(self): | |||
| logger.debug(f"_get_next_task. last_task={self.last_task}, " | |||
There was a problem hiding this comment.
please follow the logging guidelines, we do not want to format when the level is not enabled
There was a problem hiding this comment.
Thanks for mentioning, fixed in #4431
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3960
When copying the results of a restarted task, the number of failed subtasks
on the new task was being incorrectly set to the total subtasks count.
This resulted in the requestor attempting to assign more new subtasks
than necessary.