This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Fixed rpc tests after disabling concent #4393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
force-pushed
the
mwu/int-fix-rpc
branch
from
0d397ab to
efef27c
Compare
scripts/node_integration_tests/playbooks/golem/rpc_test/concent/playbook.py
Show resolved
Hide resolved
shadeofblue
suggested changes
Jun 27, 2019
There was a problem hiding this comment.
@maaktweluit it's strange that the base playbook is the one that defines the empty step... I think it should be the other way round ...
especially, that with your changes here, concent playbook is actually never used ...
shadeofblue
reviewed
Jun 27, 2019
|
@shadeofblue the "base" playbook is the default mode to run, Resolved your other comment by adding the test |
mfranciszkiewicz
approved these changes
Jun 28, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4393 +/- ##
===========================================
- Coverage 88.49% 88.48% -0.01%
===========================================
Files 225 225
Lines 19845 19845
===========================================
- Hits 17561 17560 -1
- Misses 2284 2285 +1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #4370
test_rpc/concent