node_integration_tests - Remove repeated part of datadirs

[maaktweluit]

old: scripts.node_integration_tests.tests.test_golem.GolemNodeTest.test_frame_restart
new:                                      test_golem.GolemNodeTest.test_frame_restart

[Wiezzel]

Looks ok. Do you still need to replace __name__ though?

[maaktweluit]

Was looking at that __name__ and it indeed seems not required.

@shadeofblue @etam do you know why it is there? can we safely remove it?

[codecov]

Codecov Report

Merging #4396 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #4396   +/-   ##
========================================
  Coverage    88.49%   88.49%           
========================================
  Files          225      225           
  Lines        19845    19845           
========================================
  Hits         17561    17561           
  Misses        2284     2284

[mfranciszkiewicz]

AFAICT replacing __name__ was supposed to have a similar result, GolemNodeTest.test_frame_restart in this example.

[mfranciszkiewicz]

I think it would be nicer to dynamically resolve the required path or build the relative id from the scratch. Some helpful definitions from the unittest module:

def id(self):
    return "%s.%s" % (strclass(self.__class__), self._testMethodName)

def strclass(cls):
    return "%s.%s" % (cls.__module__, cls.__qualname__)

[maaktweluit]

@Wiezzel @mfranciszkiewicz Based on the review comments i updated the PR to use __name__ again for the replacement, so the test dir always starts with the file/module name.