Skip to content
This repository has been archived by the owner on Oct 31, 2023. It is now read-only.

A different workaround for missing docker output issue #4450

Merged
merged 1 commit into from
Jul 10, 2019

Conversation

Wiezzel
Copy link

@Wiezzel Wiezzel commented Jul 10, 2019

A slightly more elegant approach. Doesn't use sleep.

Here's the test for this PR: golemfactory/golem@b080036#diff-60b01f4ff8ebc62e4b3a7185c33a38e0
And here's a triggered build for this test branch: https://buildbot.golem.network/buildbot/#/builders/9/builds/13330

Copy link
Contributor

@Krigpl Krigpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thisisgine

@codecov
Copy link

codecov bot commented Jul 10, 2019

Codecov Report

Merging #4450 into develop will increase coverage by 0.02%.
The diff coverage is 75%.

@@             Coverage Diff             @@
##           develop    #4450      +/-   ##
===========================================
+ Coverage    88.42%   88.45%   +0.02%     
===========================================
  Files          226      226              
  Lines        19955    19951       -4     
===========================================
+ Hits         17646    17648       +2     
+ Misses        2309     2303       -6

@Wiezzel Wiezzel force-pushed the docker_benchmark_output branch from b5e7054 to b4c0f8d Compare July 10, 2019 10:34
Copy link
Contributor

@maaktweluit maaktweluit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Ran the tests on the machine that broke 20+ times and it seems good

A slightly more elegant approach. Doesn't use sleep.
@Wiezzel Wiezzel force-pushed the docker_benchmark_output branch from b4c0f8d to 632a030 Compare July 10, 2019 11:51
@Wiezzel Wiezzel merged commit db63997 into develop Jul 10, 2019
@Wiezzel Wiezzel deleted the docker_benchmark_output branch July 10, 2019 13:19
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants