This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Refactor DockerCPU[Config, Runtime, Environment] for easier inheritance #4620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor: DockerCPURuntime __init__ arguments Refactor: Make it possible to provide a custom logger in DockerCPUEnvironment.__init__ Refactor: use self._logger instead of logger in DockerCPURuntime Refactor: use self._logger instead of logger in DockerCPUEnvironment Refactor: split DockerCPUEnvironment.runtime into methods
Wiezzel
approved these changes
Aug 19, 2019
maaktweluit
approved these changes
Aug 19, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4620 +/- ##
===========================================
+ Coverage 90.3% 90.32% +0.02%
===========================================
Files 227 227
Lines 20126 20132 +6
===========================================
+ Hits 18174 18185 +11
+ Misses 1952 1947 -5 |
mfranciszkiewicz
added a commit
that referenced
this pull request
Aug 29, 2019
Refactor DockerCPU[Config, Runtime, Environment] for easier inheritance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deriving
DockerCPU*is now a bit more flexible. Changes were picked from the DockerGPUEnvironment branch and will now serve as a base branch for that PR (https://github.com/golemfactory/golem/pull/4618).List of changes:
DockerCPUConfigis now adataclassDockerCPURuntime.__init__DockerCPU[Environment|Runtime]DockerCPURuntimeDockerCPUEnvironmentDockerCPUEnvironment.runtimeinto separate methods