This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
node_integration_tests: lowered the comp.tasks timeout from 60 to 2 minutes #4621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
requested review from
mfranciszkiewicz,
Krigpl,
shadeofblue and
Wiezzel
maaktweluit
changed the title
Codecov Report
@@ Coverage Diff @@
## develop #4621 +/- ##
===========================================
+ Coverage 90.3% 90.32% +0.01%
===========================================
Files 227 227
Lines 20126 20126
===========================================
+ Hits 18174 18178 +4
+ Misses 1952 1948 -4 |
shadeofblue
approved these changes
Aug 20, 2019
mfranciszkiewicz
approved these changes
Aug 20, 2019
|
@shadeofblue no extra clutter for me, it already gets the task the first time, so normally the timer is not even used. Why 3 seconds over 1? happy to change it for a good cause :) |
|
@maaktweluit I was just concerned that if - in some cases - the creation takes e.g. half a minute, you'd get 30 messages ... which seems undesirable .. |
|
@shadeofblue thanks, updated :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a task should never take this long