This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
RequestedTaskManager - Start and stop the envs #4710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krigpl
suggested changes
Sep 10, 2019
Krigpl
reviewed
Sep 11, 2019
Krigpl
suggested changes
Sep 11, 2019
maaktweluit
force-pushed
the
mwu/rtm-start-stop
branch
from
22a1456 to
84b197f
Compare
maaktweluit
force-pushed
the
mwu/rtm-start-stop
branch
from
84b197f to
fb08a1c
Compare
Krigpl
approved these changes
Sep 11, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4710 +/- ##
===========================================
- Coverage 90.3% 89.21% -1.09%
===========================================
Files 211 211
Lines 19691 19693 +2
===========================================
- Hits 17782 17570 -212
- Misses 1909 2123 +214 |
mfranciszkiewicz
previously requested changes
Sep 12, 2019
…p, lowercase the shutdown
… makes some new ones )
maaktweluit
force-pushed
the
mwu/rtm-start-stop
branch
from
8cdec99 to
906dee7
Compare
Wiezzel
suggested changes
Sep 12, 2019
|
I'm also not sure about naming the newly introduced methods |
|
@Wiezzel Made the change to Will wait with pushing till we clarify if wait_for_shutdown is needed to not trigger tests twice |
Wiezzel
reviewed
Sep 12, 2019
maaktweluit
force-pushed
the
mwu/rtm-start-stop
branch
from
5125146 to
959bd9c
Compare
|
🙈 Good catch, fixed |
Wiezzel
approved these changes
Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added quit method to RTM to shutdown all running app clients.
Mocked the
TaskServer.quit()where needed to ensure these tests do not need asyncio