This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Restart task in RTM #4712
Merged
Restart task in RTM #4712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maaktweluit
approved these changes
Sep 11, 2019
maaktweluit
suggested changes
Sep 11, 2019
| async def restart_task(self, task_id: TaskId) -> None: | ||
| task = RequestedTask.get(RequestedTask.task_id == task_id) | ||
| task.status = TaskStatus.waiting | ||
| task.save() |
There was a problem hiding this comment.
should we also discard the completed results?
There was a problem hiding this comment.
There are multiple ways of task restarts we wanna support
- restart just the failed subtasks - that's the one
- restart the whole task by creating a new one from scratch
- restart particular subtasks
There was a problem hiding this comment.
ok, should we make issues for the other 2? Do we want to support all 3 from the first release?
maaktweluit
approved these changes
Sep 11, 2019
Codecov Report
@@ Coverage Diff @@
## develop #4712 +/- ##
===========================================
- Coverage 90.27% 90.27% -0.01%
===========================================
Files 211 211
Lines 19676 19680 +4
===========================================
+ Hits 17763 17766 +3
- Misses 1913 1914 +1 |
Krigpl
force-pushed
the
restart_task
branch
from
e549dbc
to
a0febf1
Compare
mfranciszkiewicz
pushed a commit
that referenced
this pull request
Sep 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.