This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
Protect asyncio add/remove Reader/Writer against multithreading #4715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shadeofblue
approved these changes
Sep 12, 2019
Twisteds asyncioreactor uses low level eventloop api to watch file descriptors (sockets in this case). Unfortunatelly some race-condition occurs.
jiivan
force-pushed
the
b0.21-locked-monkey
branch
from
21df5c7 to
09f7dd1
Compare
Codecov Report
@@ Coverage Diff @@
## b0.21 #4715 +/- ##
==========================================
+ Coverage 90.21% 90.24% +0.03%
==========================================
Files 210 210
Lines 19542 19546 +4
==========================================
+ Hits 17630 17640 +10
+ Misses 1912 1906 -6 |
mfranciszkiewicz
approved these changes
Sep 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twisteds asyncioreactor uses low level eventloop api to watch file descriptors (sockets in this case). Unfortunatelly some race-condition occurs.